[core] Fix cgroup controller check #52443
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/fix-cgroup-controller-check
branch
from
b09577c to
83c8284
Compare
dentiny
commented
Apr 20, 2025
| cur_controller) != enabled_subtree_controllers.end()) { | ||
| if (std::find(available_controllers.begin(), | ||
| available_controllers.end(), | ||
| cur_controller) == available_controllers.end()) { |
There was a problem hiding this comment.
If the required controller is NOT available, we should error.
dentiny
commented
Apr 20, 2025
| @@ -248,8 +248,8 @@ Status CgroupSetup::InitializeCgroupV2Directory(const std::string &directory, | |||
| // Check cgroup accessibility before setup. | |||
| RAY_RETURN_NOT_OK(internal::CheckCgroupV2MountedRW(directory)); | |||
|
|
|||
| // Check cgroup subtree control before setup. | |||
| if (Status s = internal::CheckBaseCgroupSubtreeController(directory); !s.ok()) { | |||
| // Check cgroup available controllers before setup. | |||
There was a problem hiding this comment.
Before any cgroup operations, we should check available controllers, and enable subtree controllers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cgroup bugs I wrote in previous PRs. Hopefully the inline comments are clear enough.