Add more context on logs 3 files #52472
Open
+15
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fscnick <[email protected]>
Signed-off-by: fscnick <[email protected]>
|
@kevin85421 PTAL |
kevin85421
reviewed
Apr 22, 2025
src/ray/core_worker/context.cc
Outdated
| @@ -450,7 +450,7 @@ ObjectID WorkerContext::GetGeneratorReturnId(const TaskID &task_id, | |||
| // return values. | |||
| auto max_generator_returns = GetThreadContext().GetMaxNumGeneratorReturnIndex(); | |||
| if (put_index > max_generator_returns) { | |||
| RAY_LOG(FATAL) | |||
| RAY_LOG(FATAL).WithField("task_id", current_task_id) | |||
Signed-off-by: fscnick <[email protected]>
Hi @kevin85421 , I have updated screenshots in the description. |
kevin85421
approved these changes
Apr 26, 2025
…on-logs-3-files Signed-off-by: fscnick <[email protected]>
|
Hi @kevin85421, the CI has passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To benefit the log parsing, add more context on logs.
This PR addresses the following files in #52468.
screenshots:
actor_manager.cc
common.cc
context.cc
Related issue number
Closes #52469
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.