Skip to content

[core] Static Priority scheduling (4/N) #52489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

dayshah
Copy link
Contributor

@dayshah dayshah commented Apr 21, 2025

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@dayshah dayshah changed the title [core] Static Priority scheduling (3/N) [core] Static Priority scheduling (4/N) Apr 21, 2025
Signed-off-by: dayshah <[email protected]>
@dayshah dayshah force-pushed the priority-scheduling-3 branch from cd23c62 to a6460d2 Compare April 21, 2025 20:30
@dayshah dayshah force-pushed the priority-scheduling-3 branch from a6460d2 to 84ea560 Compare April 21, 2025 21:03
Signed-off-by: dayshah <[email protected]>
@dayshah dayshah force-pushed the priority-scheduling-3 branch from 84ea560 to fda833f Compare April 21, 2025 22:05
@dayshah dayshah added go add ONLY when ready to merge, run all tests and removed go add ONLY when ready to merge, run all tests labels Apr 21, 2025
@dayshah dayshah force-pushed the priority-scheduling-3 branch from fda833f to a3566be Compare April 22, 2025 20:34
@dayshah dayshah added the go add ONLY when ready to merge, run all tests label Apr 22, 2025
@dayshah dayshah requested review from jjyao and edoakes April 22, 2025 20:39
@dayshah
Copy link
Contributor Author

dayshah commented Apr 22, 2025

@jjyao don't need a real code review rn, but can you do a quick logical look over where I changed to account for priority just to make sure that there's no other spots where priority should be accounted for. Any ideas to minimize the time between:
higher priority tasks submitted -> higher priority tasks start superceding lower priority?

Can also look at the 1 -> 2 -> 3 -> 4 diffs here https://github.com/dayshah/ray/pulls for easier to see the four sets of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant