[core][refactor] Always use SetTaskStatus for task status transitions
#52637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai-Hsun Chen <[email protected]>
kevin85421
commented
Apr 28, 2025
Signed-off-by: Kai-Hsun Chen <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors task status transitions to always use the SetTaskStatus function rather than directly setting the task status.
- Updates the SetTaskStatus signature in the header to accept a state update, task info inclusion flag, and attempt number.
- Revises all call sites in task_manager.cc to pass the appropriate parameters, replacing any direct status updates.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ray/core_worker/task_manager.h | Updated SetTaskStatus function signature and corresponding documentation comments. |
| src/ray/core_worker/task_manager.cc | Adjusted all invocations of SetTaskStatus to match the new signature and behavior. |
jjyao
reviewed
Apr 28, 2025
jjyao
reviewed
Apr 28, 2025
| rpc::TaskStatus::PENDING_ARGS_AVAIL, | ||
| /* state_update */ std::nullopt, | ||
| /* include_task_info */ true, | ||
| task_entry.spec.AttemptNumber() + 1); |
There was a problem hiding this comment.
In a follow-up PR: let's move the logic to retry_task_callback so that we don't need to manually +1 to the AttemptNumber().
Signed-off-by: Kai-Hsun Chen <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
jjyao
approved these changes
Apr 28, 2025
ktyxx
pushed a commit
to ktyxx/ray
that referenced
this pull request
Apr 29, 2025
…ns (ray-project#52637) Signed-off-by: Kai-Hsun Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I am looking into #52530. I found that there are multiple places where the task status transitions. This PR unifies all task status transitions to use
SetTaskStatusand adds a log, making it easier to track the status transitions withgrep.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.