[CI] Re-enable isort for python/ray/data #52734
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslonnie
approved these changes
May 2, 2025
Comment on lines
143
to
146
| ) | ||
| from ray.core.generated.export_dataset_metadata_pb2 import ( | ||
| Operator as ProtoOperator, | ||
| ) | ||
| from ray.core.generated.export_dataset_metadata_pb2 import ( | ||
| SubStage as ProtoSubStage, | ||
| ) | ||
| from ray.core.generated.export_dataset_metadata_pb2 import ( | ||
| Topology as ProtoTopology, | ||
| ) |
There was a problem hiding this comment.
this splitting looks weird. why they are not merged but split?
There was a problem hiding this comment.
I created another PR to address this #52742
I turned this PR to draft to avoid introducing additional changes other than python/ray/data in this PR.
There was a problem hiding this comment.
@aslonnie I've rebased with the master branch and it should be good now.
python/ray/data/llm.py
Outdated
Comment on lines
6
to
10
| ) | ||
| from ray.llm._internal.batch.processor import ( | ||
| Processor, | ||
| ) | ||
| from ray.llm._internal.batch.processor import ( | ||
| ProcessorConfig as _ProcessorConfig, | ||
| ) | ||
| from ray.llm._internal.batch.processor import ( | ||
| SGLangEngineProcessorConfig as _SGLangEngineProcessorConfig, | ||
| ) | ||
| from ray.llm._internal.batch.processor import ( | ||
| vLLMEngineProcessorConfig as _vLLMEngineProcessorConfig, | ||
| ) |
There was a problem hiding this comment.
why does the splitting happen?
8 tasks
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
force-pushed
the
feature/isort-ray-data
branch
from
650166e to
7a17c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Follow-up for #52712
Related issue number
N/A
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.