-
Notifications
You must be signed in to change notification settings - Fork 6.3k
fix grafana dashboards dropdowns for data and train dashboard #52752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Alan Guo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@@ -75,7 +75,7 @@ | |||
"selected": false | |||
}, | |||
"datasource": "${datasource}", | |||
"definition": "label_values(ray_train_report_total_blocked_time_s{{{global_filters}}}, ray_train_run_name)", | |||
"definition": "query_result(count by (ray_train_run_name)(last_over_time(ray_train_report_total_blocked_time_s{{SessionName=~\"$SessionName\",{global_filters}}}[$__range])))", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be ray_train_run_name
instead of SessionName=~\"$SessionName\"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, this is right. THis is filtering the dropdown to only show train run names that are part of the selected Session.
python/ray/dashboard/modules/metrics/dashboards/train_grafana_dashboard_base.json
Outdated
Show resolved
Hide resolved
@@ -85,11 +85,11 @@ | |||
"name": "TrainRunName", | |||
"options": [], | |||
"query": { | |||
"query": "label_values(ray_train_report_total_blocked_time_s{{{global_filters}}}, ray_train_run_name)", | |||
"query": "query_result(count by (ray_train_run_name)(last_over_time(ray_train_report_total_blocked_time_s{{SessionName=~\"$SessionName\",{global_filters}}}[$__range])))", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that ray_train_report_total_blocked_time_s
may not be recorded in the case that the user does not call ray.train.report
. Would it be better to use a metric that will always be recorded? E.g. right now ray_train_worker_group_start_total_time_s
should always be there.
Signed-off-by: Alan Guo <[email protected]>
Why are these changes needed?
Previously the dropdown for variables for data and train dashboard wasn't working for a few reasons:
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.