Skip to content

[RLlib; Offline RL] Fix weight synching in offline evaluation. #52757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[RLlib; Offline RL] Fix weight synching in offline evaluation. #52757

wants to merge 4 commits into from

Conversation

simonsays1980
Copy link
Collaborator

@simonsays1980 simonsays1980 commented May 2, 2025 •
edited
Loading

… single local runner and (2) synching weights in general.

Why are these changes needed?

Due to two small bugs offline evaluation runners cannot update their weights. This PR fixes these bugs.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simonsays1980
Fixed two bugs in offline evaluation that was (1) avoiding updating a…
9179c41 
… single local runner and (2) synching weights in general.

Signed-off-by: simonsays1980 <[email protected]>
@simonsays1980 simonsays1980 marked this pull request as ready for review May 2, 2025 21:15
@simonsays1980 simonsays1980 requested a review from sven1977 as a code owner May 2, 2025 21:15
@sven1977 sven1977 changed the title [RLlib; Offline RL] - Fix weight synching in offline evaluation. [RLlib; Offline RL] Fix weight synching in offline evaluation. May 5, 2025
sven1977
sven1977 approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix @simonsays1980 !

@sven1977 sven1977 enabled auto-merge (squash) May 5, 2025 09:37
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonsays1980 @sven1977