[WIP] Investigating why batching streaming is not helping with the streaming overhead #52766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the LLMServer and vLLMEngine so that streaming batching happens at the LLMServing layer instead of vLLMEngine.
I also noticed that if vLLMEngine does the batching then the LLMServer will unpack the batch and stream the individual items through the remote channel back to the router. This is a problem at high qps where ray's streaming becomes the botteleneck and the whole end to end latency will be impacted by the streaming issue. With proper batching we can mitigate this problem which was not happening before due to the extra unpacking done at the wrong layer. Unpacking should be done at the very last stage when router wants to send back the results to the http proxy.
TODO: