Skip to content

Conversation

@srinathk10
Copy link
Contributor

@srinathk10 srinathk10 commented Nov 21, 2025

Thank you for contributing to Ray! 🚀
Please review the Ray Contribution Guide before opening a pull request.

⚠️ Remove these instructions before submitting your PR.

💡 Tip: Mark as draft if you want early feedback, or ready for review when it's complete.

Description

Briefly describe what this PR accomplishes and why it's needed.

[Data] Add iter_prefetched_blocks stats

Report prefetched bytes per iterator as stats.

Related issues

Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234".

Additional information

Optional: Add implementation details, API changes, usage examples, screenshots, etc.

Signed-off-by: Srinath Krishnamachari <[email protected]>
@srinathk10 srinathk10 requested a review from a team as a code owner November 21, 2025 22:19
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new metric, iter_prefetched_blocks_count, to track the number of prefetched blocks in a Ray Data iterator. The changes are well-integrated, spanning from the core data processing logic to the dashboard for visualization. The implementation is sound and aligns with the existing metrics framework. I have one suggestion to remove a redundant piece of code to improve clarity.

@srinathk10 srinathk10 added go add ONLY when ready to merge, run all tests data Ray Data-related issues labels Nov 21, 2025
Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's report size bytes instead.

@srinathk10 srinathk10 changed the title [Data] Add iter_prefetched_blocks stats [Data] Add iter_prefetched_bytes stats Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Ray Data-related issues go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ray fails to serialize self-reference objects

3 participants