[Doc]Update gke gcs bucket instructions to use workload identity #58901
+22
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siyuan Zhang <[email protected]>
Author
|
/cc @andrewsykim |
andrewsykim
reviewed
Nov 24, 2025
| def check_gcs_read_write(): | ||
| client = storage.Client() | ||
| bucket = client.get_bucket(GCP_GCS_BUCKET) | ||
| bucket = client.bucket(GCP_GCS_BUCKET) |
Member
There was a problem hiding this comment.
Why was the change from get_bucket to bucket required?
|
|
||
| ```bash | ||
| kubectl create serviceaccount my-ksa | ||
| KSA=my-ksa |
Member
There was a problem hiding this comment.
can you also set NAMESPACE and pass it in -n below?
| iam.gke.io/gcp-service-account=my-iam-sa@my-project-id.iam.gserviceaccount.com | ||
| PROJECT_ID=<your project ID> | ||
| PROJECT_NUMBER=<your project number> | ||
| gcloud storage buckets add-iam-policy-binding gs://${BUCKET} --member "principal://iam.googleapis.com/projects/${PROJECT_NUMBER}/locations/global/workloadIdentityPools/${PROJECT_ID}.svc.id.goog/subject/ns/default/sa/${KSA}" --role "roles/storage.objectUser" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update gke gcs bucket instructions to use workload identity
to be consistent with https://docs.ray.io/en/master/cluster/kubernetes/examples/distributed-checkpointing-with-gcsfuse.html#configuring-the-gcs-bucket
Related issues
Additional information