[ci] windows: run tests on python 3.10 #58920
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Python version for Windows builds from 3.9 to 3.10, which is a necessary change as Python 3.9 has reached its end of life. The change itself is correct. I've added one suggestion to improve the Dockerfile's flexibility and maintainability by using a build argument for the Python version, which is a common practice in this repository.
| FROM $DOCKER_IMAGE_BASE_BUILD | ||
|
|
||
| ENV PYTHON=3.9 | ||
| ENV PYTHON=3.10 |
There was a problem hiding this comment.
For better flexibility and consistency with other Dockerfiles in this repository (e.g., ci/docker/base.test.Dockerfile), it's a good practice to define the Python version as a build argument (ARG) and then use it to set the environment variable (ENV). This allows overriding the Python version during the Docker build process if needed, without modifying the Dockerfile.
ARG PYTHON=3.10
ENV PYTHON=$PYTHON
also add windows tags to windows test jobs Signed-off-by: Lonnie Liu <[email protected]>
aslonnie
force-pushed
the
lonnie-251122-winpyup
branch
from
3a97e7a to
546d33d
Compare
|
testing with all windows tests: |
python 3.9 is end of life