-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Implementing Null Handling(is_finite, is_inf, is_nan) #59876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rob12312368
wants to merge
7
commits into
ray-project:master
Choose a base branch
from
Rob12312368:issue_58674
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+69
−2
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b46766e
done with is_nan, is_finite, and is_inf. will open another pr draft f…
Rob12312368 9209cc5
Merge branch 'master' into issue_58674
goutamvenkat-anyscale c5e902a
Update python/ray/data/expressions.py
Rob12312368 d9f84a2
fix based on suggestion from ai - specify return type and modify tests
Rob12312368 58b3306
Merge branch 'master' into issue_58674
goutamvenkat-anyscale e78c6f2
change test to another file
Rob12312368 847ae6e
change test to another file
Rob12312368 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing docstrings on new public API methods
Low Severity
The new
is_nan,is_finite, andis_infmethods are the only public methods on this class without docstrings. Every other method — including short ones likeceil,floor, andtrunc— has at least a one-line docstring. This inconsistency makes these methods harder to discover and use, especially since they're part of a public API.