[ci] removing requirement file and constraint file build args

[elliot-barn]

removing requirement file and constraint file build args from the following images
base-deps
base-extra
base-extra-test-deps
base-slim (add constraints file as build arg)

defaulting PYTHON_DEPSET & CONSTRAINTS_FILE args in the dockerfile

Renaming ray-llm, ray-gpu & ray base extra testdeps lock files. IMAGE_TYPE defined on the BK jobs will determine which lock file to copy to the image

hello world release test run: https://buildkite.com/ray-project/release/builds/75854

[gemini-code-assist]

Code Review

This pull request refactors the Docker image build process by moving build arguments like REQUIREMENTS_FILE and CONSTRAINTS_FILE into the Dockerfiles as ARG with default values. This is a good simplification of the CI configuration. However, I've found several critical issues that will likely cause build failures, including a missing build argument declaration, incomplete source file lists, and an incorrect build argument that would override a default with an empty value. I've also pointed out some medium-severity issues where unused files are included in the build context, which should be cleaned up.

[gemini-code-assist]

This build_arg should be removed. REQUIREMENTS_FILE is no longer defined in the CI configuration, so $REQUIREMENTS_FILE will be empty. This will override the default PYTHON_DEPSET in the Dockerfile with an empty string, causing the COPY command to fail.

[gemini-code-assist]

The default value for PIP_REQUIREMENTS uses ${PYTHON_VERSION}, but PYTHON_VERSION is not declared as a build argument in this Dockerfile. This will cause ${PYTHON_VERSION} to be an empty string, leading to a build failure when trying to copy the requirements file. You should declare PYTHON_VERSION as an ARG before it's used.

ARG PYTHON_VERSION="3.10"
ARG PIP_REQUIREMENTS="python/deplocks/base_extra_testdeps/ray_base_extra_testdeps_py${PYTHON_VERSION}.lock"

[gemini-code-assist]

This srcs entry for python/requirements_compiled.txt appears to be unnecessary. The corresponding docker/base-deps/Dockerfile has been updated to use the $CONSTRAINTS_FILE build argument, which defaults to python/requirements_compiled_py${PYTHON_VERSION}.txt, and no longer directly copies python/requirements_compiled.txt. To keep the build context clean and avoid confusion, this line can be removed.

[gemini-code-assist]

The srcs entry for python/requirements_compiled.txt seems to be redundant. The docker/base-deps/Dockerfile now uses the $CONSTRAINTS_FILE build argument instead of hardcoding this path. Removing this line will help keep the build context minimal.

[gemini-code-assist]

The srcs entry for python/requirements_compiled.txt appears to be unused. The corresponding docker/base-slim/Dockerfile has been updated to use $CONSTRAINTS_FILE and no longer copies python/requirements_compiled.txt directly. You can remove this line to keep the build context clean.

[aslonnie]

when this is copied in, this will overwrite the one that is copied in from base-deps?

[elliot-barn]

correct. Should overwrite the existing base-deps lock file

[cursor]

Ray-ML testdeps build uses wrong lock file path

High Severity

The ray-mlcudabaseextra-testdeps build previously used REQUIREMENTS_FILE: "python/deplocks/base_extra_testdeps/ray_ml_base_extra_testdeps_cuda_py..." with the ray_ml_ prefix. This was removed without providing an alternative mechanism. The hardcoded srcs path in cuda.wanda.yaml and the PIP_REQUIREMENTS default in byod.Dockerfile both reference ray_base_extra_testdeps_cuda_py... (without ray_ml_ prefix), but separate lock files exist for ray-ml as shown in the depsets configuration. The ray-ml CUDA testdeps build will fail.

Additional Locations (1)

• release/ray_release/byod/byod.Dockerfile#L8-L9