-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[DO NOT MERGE] Debug test_object_spilling #60225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: davik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces temporary changes to a Buildkite CI pipeline configuration to facilitate debugging a failing test on Windows. The changes force a test step to pass and then introduce an 8-hour sleep to keep the build agent alive for inspection. My review highlights the significant risks of these changes, such as masking test failures and wasting CI resources, should they be accidentally merged. I've raised a critical issue regarding this and suggested using a more robust and efficient tool like tmate for interactive debugging in the future to avoid such risky workarounds.
.buildkite/windows.rayci.yml
Outdated
| || true | ||
| - sleep 28800 # 8 hours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes appear to be for debugging a failing test. While this is a common pattern, these additions are very dangerous if accidentally merged:
|| true: This will permanently mask any failures in this test step, causing the build to appear successful even when tests are failing.sleep 28800: This blocks a CI agent for 8 hours, which is a major waste of resources and can delay other builds.
While the PR is correctly marked as "DO NOT MERGE", it's better to use safer debugging techniques to avoid the risk of accidental merges. For interactive debugging, consider using a tool like tmate to create a secure, on-demand terminal session. This provides shell access for debugging without needing to hardcode a long sleep or mask test results.
Signed-off-by: davik <[email protected]>
Signed-off-by: davik <[email protected]>
Signed-off-by: davik <[email protected]>
Signed-off-by: davik <[email protected]>
Signed-off-by: davik <[email protected]>
Signed-off-by: davik <[email protected]>
Signed-off-by: davik <[email protected]>
Signed-off-by: davik <[email protected]>
Signed-off-by: davik <[email protected]>
Signed-off-by: davik <[email protected]>
No description provided.