[release test] remove stable field handling #60263
Open
+2
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a test is not stable, it should be on manual frequency. Signed-off-by: Lonnie Liu <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the stable field from test configurations and the associated logic that treats unstable tests differently. This is a good simplification, making the test stability handling more straightforward by relying on the frequency field (e.g., manual for unstable tests). The changes are applied consistently across Python code, YAML configurations, and tests. My review includes one suggestion to remove a now-unused method to further improve code maintainability.
I am having trouble creating individual review comments. Click here to see my feedback.
release/ray_release/test_automation/release_state_machine.py (70-73)
With the removal of this logic, the Test.is_stable() method in release/ray_release/test.py appears to be unused and can be removed as part of this cleanup. This will improve code maintainability by removing dead code.
ray-gardener
bot
added
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a test is not stable, it should be on manual frequency. we will no longer treat unstable tests differently.