[release test] remove job manager aliasing in __init__.py
#60264
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this clears all the `__init__.py` under `ray_release/` directory. making it consistent with other files, and easier to convert everything to idiomatic bazel Signed-off-by: Lonnie Liu <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the re-export of AnyscaleJobManager from the ray_release.job_manager package by clearing its __init__.py file. This change makes imports more explicit, which is a positive step towards better code organization and maintainability. As mentioned in the description, this refactoring will also facilitate the adoption of Bazel. The change is simple, effective, and I see no issues with it.
ray-gardener
bot
added
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the alias is not used anywhere.
this clears all the
__init__.pyunderray_release/directory. making it consistent with other files, and easier to convert everything to idiomatic bazel