[release test] remove sdk property in AnyscaleJobManager#60277
Merged
aslonnie merged 1 commit intoray-project:masterfrom Jan 20, 2026
Merged
[release test] remove sdk property in AnyscaleJobManager#60277aslonnie merged 1 commit intoray-project:masterfrom
aslonnie merged 1 commit intoray-project:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors AnyscaleJobManager to cache the Anyscale SDK instance in a private _sdk member instead of accessing it through a property. This is a good change that simplifies the code and avoids repeated property lookups. My review includes a suggestion to add a type hint for the new _sdk attribute to improve code clarity and maintainability.
| self.start_time = None | ||
| self.counter = 0 | ||
| self.cluster_manager = cluster_manager | ||
| self._sdk = cluster_manager.sdk |
Contributor
There was a problem hiding this comment.
To improve code clarity and maintainability, it's a good practice to add a type hint for the new private member _sdk.
For this to work, you'll also need to add the following imports at the top of the file:
from typing import TYPE_CHECKING
if TYPE_CHECKING:
from anyscale.sdk.anyscale_client.sdk import AnyscaleSDK
Suggested change
| self._sdk = cluster_manager.sdk | |
| self._sdk: "AnyscaleSDK" = cluster_manager.sdk |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
aslonnie
force-pushed
the
lonnie-260118-managersdk
branch
from
91b0803 to
a688c2e
Compare
aslonnie
force-pushed
the
lonnie-260118-managersdk
branch
2 times, most recently
from
533c479 to
915f10f
Compare
just save the sdk as a private member instead Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
aslonnie
force-pushed
the
lonnie-260118-managersdk
branch
from
915f10f to
5ae14d2
Compare
ray-gardener
bot
added
core
andrew-anyscale
approved these changes
Jan 20, 2026
jinbum-kim
pushed a commit
to jinbum-kim/ray
that referenced
this pull request
Jan 29, 2026
…#60277) just save the sdk as a private member instead Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Feb 1, 2026
…#60277) just save the sdk as a private member instead Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Signed-off-by: 400Ping <jiekaichang@apache.org>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
…#60277) just save the sdk as a private member instead Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just save the sdk as a private member instead