[release test] convert job_id and job_url into methods#60278
Merged
aslonnie merged 3 commits intoray-project:masterfrom Jan 20, 2026
Merged
[release test] convert job_id and job_url into methods#60278aslonnie merged 3 commits intoray-project:masterfrom
aslonnie merged 3 commits intoray-project:masterfrom
Conversation
aslonnie
force-pushed
the
lonnie-260118-jobid
branch
from
ff307cc to
2483350
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors job_id and job_url in AnyscaleJobManager from properties to methods, caching the job ID for clarity and simplicity. The changes are mostly straightforward, but I've found a critical issue in glue.py where a None check for command_runner was removed, which could lead to a crash if the test setup fails. I've also made a minor suggestion to add a missing newline at the end of a file.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aslonnie
force-pushed
the
lonnie-260118-jobid
branch
2 times, most recently
from
932e57f to
cc53cb2
Compare
ray-gardener
bot
added
core
and saves the job ID in `_job_id`. this makes the information flow clearer and simpler. this is preparation for refactoring the job sdk usage. Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
aslonnie
force-pushed
the
lonnie-260118-jobid
branch
from
01cd8fb to
b7f9b07
Compare
andrew-anyscale
approved these changes
Jan 20, 2026
Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
jinbum-kim
pushed a commit
to jinbum-kim/ray
that referenced
this pull request
Jan 29, 2026
…0278) and saves the job ID in `_job_id`. this makes the information flow clearer and simpler. this is preparation for refactoring the job sdk usage. Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Feb 1, 2026
…0278) and saves the job ID in `_job_id`. this makes the information flow clearer and simpler. this is preparation for refactoring the job sdk usage. Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Signed-off-by: 400Ping <jiekaichang@apache.org>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
…0278) and saves the job ID in `_job_id`. this makes the information flow clearer and simpler. this is preparation for refactoring the job sdk usage. Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and saves the job ID in
_job_id. this makes the information flow clearer and simpler.this is preparation for refactoring the job sdk usage.