[Data] Add TPCH queries 3, 10, and 18 for benchmarking#60667
Open
daiping8 wants to merge 5 commits intoray-project:masterfrom
Open
[Data] Add TPCH queries 3, 10, and 18 for benchmarking#60667daiping8 wants to merge 5 commits intoray-project:masterfrom
daiping8 wants to merge 5 commits intoray-project:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds several new TPC-H query benchmarks (Q3, Q5, Q7, Q8, Q9, Q10, and Q18). The implementations are a great addition. However, there is a recurring critical issue across all new query files regarding the usage of Dataset.join. The method is consistently called with on and right_on parameters for joining columns with different names, which is not the correct API usage. The correct parameters are left_on and right_on. This needs to be fixed to ensure the queries run correctly. Additionally, I've identified some opportunities for performance improvements and code simplification in queries Q5, Q8, and Q10.
daiping8
force-pushed
the
tpchq3
branch
3 times, most recently
from
79af0a5 to
bf0c428
Compare
Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
daiping8
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
ray-gardener
bot
added
data
…on tables Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
daiping8
changed the title
Contributor
Author
|
@owenowenisme Please review the code. Looking forward to any suggestions. |
owenowenisme
reviewed
Feb 6, 2026
…tions Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding Query Q3, Q10, Q18, for TPCH tests