[core] fix dashboard event agent for reporting events without http scheme#60811
Draft
rueian wants to merge 2 commits intoray-project:masterfrom
Draft
[core] fix dashboard event agent for reporting events without http scheme#60811rueian wants to merge 2 commits intoray-project:masterfrom
rueian wants to merge 2 commits intoray-project:masterfrom
Conversation
…heme Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in the event agent where it fails to report events to the dashboard due to a missing HTTP scheme in the URL. The change correctly prepends http:// to the dashboard address. I've added a suggestion to make this logic more robust by checking if a scheme already exists before adding it, which will prevent potential issues in the future if the format of the stored address changes.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Rueian <rueiancsie@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
event_agent.pyfails to report events to the dashboard for a long time. It fails withaiohttp.client_exceptions.NonHttpUrlClientErrorbecause the address doesn't start with ahttp://scheme.This PR adds the http scheme.
Related issues
Additional information