Skip to content

[Data] Remove get_internal_block_refs#62958

Open
kyuds wants to merge 3 commits into
ray-project:masterfrom
kyuds:depr-get-internal-block-refs
Open

[Data] Remove get_internal_block_refs#62958
kyuds wants to merge 3 commits into
ray-project:masterfrom
kyuds:depr-get-internal-block-refs

Conversation

@kyuds

@kyuds kyuds commented Apr 26, 2026

Copy link
Copy Markdown
Member

Description

get_internal_block_refs has been marked deprecated for over a year. We should remove it.

Related issues

N/A

Additional information

N/A

Signed-off-by: Daniel Shin <kyuseung1016@gmail.com>
@kyuds kyuds requested a review from a team as a code owner April 26, 2026 20:28
@kyuds kyuds requested a review from bveeramani April 26, 2026 20:28
@kyuds kyuds added the go add ONLY when ready to merge, run all tests label Apr 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated get_internal_block_refs method from the Dataset class and updates the test suite to use iter_internal_ref_bundles as the replacement. I have no feedback to provide.

@bveeramani bveeramani enabled auto-merge (squash) April 26, 2026 21:30
@kyuds

kyuds commented Apr 26, 2026

Copy link
Copy Markdown
Member Author

@bveeramani daft seems to use this deprecated api so tests are failing...

@bveeramani

Copy link
Copy Markdown
Member

@richardliaw how should we proceed here?

@ray-gardener ray-gardener Bot added data Ray Data-related issues community-contribution Contributed by the community labels Apr 27, 2026
@kyuds

kyuds commented May 3, 2026

Copy link
Copy Markdown
Member Author

blocked on Daft: Eventual-Inc/Daft#6870

@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions Bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label May 18, 2026
Signed-off-by: Daniel Shin <kyuseung1016@gmail.com>
@github-actions github-actions Bot disabled auto-merge May 27, 2026 07:17
@kyuds

kyuds commented May 27, 2026

Copy link
Copy Markdown
Member Author

Daft PR is merged, but holding this for now because we need to update Daft dependency for our tests. @richardliaw what do you think about skipping the daft tests for now? Happy to hold this until Daft releases a new version and update dependencies accordingly as well.

@github-actions github-actions Bot added unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it. and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels May 27, 2026
@bveeramani

Copy link
Copy Markdown
Member

Holding off seems like the responsible move vs. skipping tests.

@kyuds would you mind pinging the Eventual team and asking them when they're planning to ship their next release? IIRC they release every two weeks or something

@kyuds

kyuds commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

@elliot-barn I need to update Daft to v0.7.15 (their latest version) to pass tests on this deprecation. Could you guide me on how to do this? cc @bveeramani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community data Ray Data-related issues go add ONLY when ready to merge, run all tests unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants