[core] Remove experimental _owner support for ray.put#63520
Conversation
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the experimental functionality that allowed users to manually assign an owner to objects created via ray.put. The changes involve removing the _owner parameter from the Python API, the owner parameter from the Java API, and the underlying AssignObjectOwner RPC and reference counting logic in the C++ Core Worker. Additionally, corresponding tests, Ray Client support, and internal protobuf definitions for this feature have been deleted across the codebase. I have no feedback to provide as there were no review comments to assess.
…es/remove-owner
edoakes
changed the title
_owner_owner support for ray.put
|
FYI @pang-wu -- removing this starting in Ray 2.56 as we discussed offline. |
edoakes
requested review from
a team,
SongGuyang,
WangTaoTheTonic,
kfstorm and
raulchen
as code owners
edoakes
force-pushed
the
eoakes/remove-owner
branch
from
fd6e85d to
d06d01e
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit d06d01e. Configure here.
…es/remove-owner
…t#63520) Removes the experimental argument to assign a different owner when `ray.put`ing an object. This adds additional branches to the (already complex) object ownership model. This experimental argument was originally added for RayDP, but its use was removed in: ray-project/raydp@5a98b1e --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Neelansh Khare <kharen@uci.edu>
2 participants
Removes the experimental argument to assign a different owner when
ray.puting an object. This adds additional branches to the (already complex) object ownership model.This experimental argument was originally added for RayDP, but its use was removed in: ray-project/raydp@5a98b1e