[core] Deflake test_ray_shutdown#63573
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the test_ray_shutdown test to use a SignalActor for more reliable synchronization instead of time.sleep. Feedback suggests restoring the explicit ray.init() call to ensure a clean test state and replacing the list comprehension used for task submission with a standard for loop to follow Pythonic idioms.
…es/deflake-shutdown
…es/deflake-shutdown
Neelansh-Khare
pushed a commit
to Neelansh-Khare/ray-clone
that referenced
this pull request
Jun 5, 2026
Flaking in CI waiting for tasks to start running: https://buildkite.com/ray-project/postmerge/builds/17674#019e48ed-4294-4a89-b86b-eed66cd804b0/L1281 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Neelansh Khare <kharen@uci.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flaking in CI waiting for tasks to start running: https://buildkite.com/ray-project/postmerge/builds/17674#019e48ed-4294-4a89-b86b-eed66cd804b0/L1281