[serve] haproxy grpc#63735
Draft
akyang-anyscale wants to merge 16 commits into
Draft
Conversation
support for haproxy grpc known limitations: * streaming (to be implemented) * metrics (to be implemented) * healthz response is changed such that the response object is None. The message is in the grpc call details instead of the response now (because of haproxy limitations). The status code is unchanged (still `OK` on healthy and `UNAVAILABLE` otherwise). * ListApplications request is forwarded to the serve proxy, so it does not work if serve proxy is down. --------- Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Make haproxy http2 tuning parameters adjustable via env var --------- Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces gRPC support for HAProxy in Ray Serve, adding HTTP/2 tuning flags, a gRPC frontend, and health check configurations. Feedback on the changes highlights three key improvements: adding the missing check parameter to gRPC backend servers to enable active health checking, handling empty backend scenarios in the gRPC healthz template to avoid confusing NOT_FOUND errors, and initializing self._grpc_fallback_target in __init__ to prevent potential AttributeErrors.
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Additional information