[doc][KubeRay] Add NetworkPolicy user guide + kuberay namespace note - #65074
[doc][KubeRay] Add NetworkPolicy user guide + kuberay namespace note#65074chipspeak wants to merge 1 commit into
Conversation
b65acbc to
38dbe13
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the KubeRay operator installation guide to use a dedicated ray-system namespace by default and introduces a comprehensive user guide for configuring RayCluster with NetworkPolicies. The review feedback identifies a critical issue in the Kustomize configuration example where a strategic merge patch would overwrite the operator's default arguments and break its functionality, recommending a JSON 6902 patch instead. Additionally, it suggests simplifying the validation instructions since the ray-system namespace is now the default for all installation methods.
| ## Step 3: Validate Installation | ||
|
|
||
| Confirm that the operator is running in the namespace `default`. | ||
| Confirm that the operator is running. If you installed into `ray-system`, pass `-n ray-system`: |
There was a problem hiding this comment.
Since both Method 1 (Helm) and Method 2 (Kustomize) in the updated guide now install the operator into the ray-system namespace by default, the conditional phrasing "If you installed into ray-system" is no longer necessary.
We can simplify this to:
Confirm that the operator is running in the `ray-system` namespace:There was a problem hiding this comment.
@machichima I'm happy to still have this in just to double down on the ray-system namespace advice but I can change it to the above too depending on what you think.
Signed-off-by: Pat O'Connor <paoconno@redhat.com> Co-authored-by: David Adamache <dadamach@redhat.com> Co-authored-by: Paul Nolan <pnolan@redhat.com>
38dbe13 to
826d9a4
Compare
Description
Adding documentation around the new NetworkPolicy feature in KubeRay.
Related issues
ray-project/kuberay#5030
Additional information
N/A