[Data] Expose RAY_DATA_HASH_SHUFFLE_MAP_TASK_TARGET_INPUT_BYTES in Data context - #65103
Open
owenowenisme wants to merge 3 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the pre_map_merge_threshold parameter in ShuffleMapOp with a context-based configuration hash_shuffle_map_task_target_input_bytes (defaulting to 128 MiB), allowing dynamic configuration of the target input size for hash-shuffle map tasks. The review feedback suggests using pytest's monkeypatch fixture in the new test instead of a manual try...finally block to restore the context state, which is cleaner and more idiomatic.
owenowenisme
added
data
Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set the default map task target input size to 128 MiB (previously hard-coded to 1 GiB). When the map side is CPU-intensive and CPU resources are abundant, a 1 GiB threshold caps parallelism: each node buffers a full 1 GiB before launching a single map task, leaving cores idle while the buffer fills. 128 MiB matches target_max_block_size, giving shuffle map tasks the same input granularity as other Ray Data tasks. Users can still config this with data context.
Related issues
Additional information