This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Deterministic mode is not set on remote worker #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusSpanring
commented
Sep 23, 2022
| @@ -316,18 +320,20 @@ def _collect_rank_zero_results(self, trainer: "pl.Trainer", | |||
| This function is run on the worker process. | |||
| """ | |||
| rank_zero_debug("Finalizing the Ray launcher environment.") | |||
| if trainer.strategy.global_rank != 0: | |||
There was a problem hiding this comment.
Is it save to use trainer.strategy instead of self._strategy?
MarkusSpanring
commented
Sep 23, 2022
| # Set operations to deterministic in this worker when required | ||
| if trainer._accelerator_connector.deterministic: | ||
| trainer._accelerator_connector._init_deterministic(True) | ||
|
|
||
| results = function(*args, **kwargs) | ||
|
|
||
| if trainer is not None: |
There was a problem hiding this comment.
Why is this check needed? Is there a case when trainer can be None?
MarkusSpanring
commented
Sep 23, 2022
| results = self._collect_rank_zero_results(trainer, results) | ||
|
|
||
| if results is None: | ||
| trainer._teardown() |
There was a problem hiding this comment.
Why do we need to tear down trainer only when local_rank or global_rank is !=0?
|
@JiahaoYao if you have time, could you check if |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix related to #213
This PR should also fix an unreachable code segment introduced in my previous PR #208