Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Tear down workers after a trial is terminated by a scheduler #254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions ray_lightning/launchers/ray_launcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,19 @@ def launch(self,
This function is run on the driver process.
"""
self.setup_workers()
ray_output = self.run_function_on_workers(
function, *args, trainer=trainer, **kwargs)
try:
ray_output = self.run_function_on_workers(
function, *args, trainer=trainer, **kwargs)

if trainer is None:
raise NotImplementedError(
"Ray launcher does not support trainer is None!")
self._recover_results_in_main_process(ray_output, trainer)
return_value = ray_output.trainer_results
finally:
self.teardown_workers()
self._strategy.teardown()

if trainer is None:
raise NotImplementedError(
"Ray launcher does not support trainer is None!")
self._recover_results_in_main_process(ray_output, trainer)
return_value = ray_output.trainer_results

self.teardown_workers()
self._strategy.teardown()
return return_value

def setup_workers(self, tune_enabled: bool = True) -> None:
Expand Down