Skip to content

fix(raycicmd): add skip to commandStepAllowedKeys #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomasdesr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(raycicmd): add skip to commandStepAllowedKeys #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion raycicmd/rayci_pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ var (
triggerStepDropKeys = []string{"tags"}

commandStepAllowedKeys = []string{
"command", "commands", "priority", "parallelism", "if",
"command", "commands", "priority", "parallelism", "if", "skip",
"label", "name", "key", "depends_on", "soft_fail", "matrix",
"allow_dependency_failure", "concurrency", "concurrency_group",
"timeout_in_minutes",
Comment on lines +49 to 52
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and readability, consider sorting these keys alphabetically. A sorted list makes it easier to check for the existence of a key and to avoid adding duplicates in the future.

Suggested change
"command", "commands", "priority", "parallelism", "if", "skip",
"label", "name", "key", "depends_on", "soft_fail", "matrix",
"allow_dependency_failure", "concurrency", "concurrency_group",
"timeout_in_minutes",
"allow_dependency_failure", "command", "commands", "concurrency", "concurrency_group",
"depends_on", "if", "key", "label", "matrix",
"name", "parallelism", "priority", "skip", "soft_fail",
"timeout_in_minutes",

Expand Down