feat(wanda): add artifacts_dir CLI flag

[andrew-anyscale]

Add -artifacts_dir flag to specify artifact extraction directory.

Topic: wanda-artifact-cli
Relative: wanda-artifact-copy

Signed-off-by: andrew andrew@anyscale.com

[andrew-anyscale]

Reviews in this chain:
└#407 feat(wanda): add Artifact struct to spec for extraction
　└#411 feat(wanda): implement artifact extraction using docker cp
　　└#409 feat(wanda): add artifacts_dir CLI flag
　　　└#410 feat(raycicmd): set RAYCI_ARTIFACTS_DIR for wanda steps

[andrew-anyscale]

#	head	base	diff	date	summary
0	e45039da	ae920eeb	diff	Feb 3 13:24 PM	1 file changed, 6 insertions(+)
1	3ba30cbe	a3b19fc3	diff	Feb 3 14:18 PM	1 file changed, 1 insertion(+), 1 deletion(-)
2	b0cff492	80ab6e0b	rebase	Feb 3 14:24 PM	0 files changed
3	2f92adb8	81385ecc	rebase	Feb 3 17:51 PM	0 files changed
4	81f41f5d	1e3c63b9	rebase	Feb 4 14:22 PM	0 files changed
5	3920c222	217cc4d4	rebase	Feb 4 14:27 PM	0 files changed
6	5f986153	34ea72c0	diff	Feb 4 15:12 PM	0 files changed
7	e090ae8f	868f0c18	rebase	Feb 4 15:29 PM	0 files changed
8	cefe4d92	f210797c	rebase	Feb 5 8:32 AM	0 files changed
9	bd707914	f343d80f	rebase	Feb 5 11:38 AM	0 files changed
10	5c06796d	44d0999e	rebase	Feb 5 11:59 AM	0 files changed

[gemini-code-assist]

Summary of Changes

Hello @andrew-anyscale, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the wanda tool by introducing a new command-line flag and environment variable to control the base directory where build artifacts are extracted. This change provides greater flexibility for users to customize artifact storage locations and ensures better integration with RayCI's artifact collection mechanisms by establishing a consistent default path in RayCI environments.

Highlights

• New CLI Flag for Artifact Directory: Introduces the -artifacts_dir command-line flag, allowing users to explicitly define the base directory for artifact extraction. This flag defaults to /tmp/artifacts when Wanda is operating in RayCI mode, aligning with standard artifact collection paths.
• Environment Variable Support: The artifacts_dir can now also be configured via the RAYCI_ARTIFACTS_DIR environment variable, providing an alternative and flexible method for setting the artifact extraction path, especially in automated environments.
• Integration into Wanda Configuration: The value obtained from either the new CLI flag or the environment variable is now properly integrated into the Wanda configuration structure, ensuring that the specified artifact directory is utilized by the application's logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• wanda/wanda/main.go
  • Added a new command-line flag, artifacts_dir, to specify the base directory for artifact extraction.
  • Implemented logic to read the artifacts_dir value from the RAYCI_ARTIFACTS_DIR environment variable if set.
  • Passed the artifactsDir value into the WandaConfig struct, making it accessible for further processing within the application.

Activity

• The pull request is currently in a draft state, indicating ongoing work or that it is not yet ready for final review.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces an artifacts_dir command-line flag to specify the directory for artifact extraction. The changes correctly add the flag and integrate it into the configuration. However, the implementation for the default artifact directory in RayCI mode is incomplete. My review includes a suggestion to correctly handle the default value, while also considering precedence of environment variables and flags.