[ecosystem CI] pass BUILDKITE_ANALYTICS_TOKEN into test job containers - #499
Merged
Merged
Conversation
Ecosystem CI test jobs run under the docker plugin with propagate-environment: false and an explicit environment allowlist, so pipeline-level env vars are dropped at the container boundary. Allowlist BUILDKITE_ANALYTICS_TOKEN (name only; the value is set as pipeline-level env in the Buildkite UI) so Test Engine collectors inside the test suites can report results. The token matches the agent's *_TOKEN redaction pattern, and analytics tokens are write-only (test-result uploads for a single suite). Signed-off-by: Ray CI Test <rayci@ray.io>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ecosystem CI test jobs run under the
docker#v5.3.0plugin withpropagate-environment: falseand an explicitenvironmentallowlist inecosystem_ci/step.json— so pipeline-level env vars are dropped at the container boundary and never reach the test suites.This allowlists
BUILDKITE_ANALYTICS_TOKEN(name only — the value is being set as pipeline-level env in the Buildkite UI for the KubeRay ecosystem pipeline) so Buildkite Test Engine collectors running inside the test containers can upload results.Safety notes:
BUILDKITE_ANALYTICS_TOKENmatches the agent's*_TOKENlog-redaction pattern.Testing
python3 -c "import json; ..."—step.jsonparses and the var is present in the docker pluginenvironmentlist;build_pipeline.pyconsumes this file as-is (deep-copies the base step), so no code change is needed.AI assistance (Claude Code) was used; reviewed by the submitter.
🤖 Generated with Claude Code