modify ray_cluster master settings to accept and pass on runtime_env#420
Open
g-clef wants to merge 2 commits intoray-project:masterfrom
Open
modify ray_cluster master settings to accept and pass on runtime_env#420g-clef wants to merge 2 commits intoray-project:masterfrom
g-clef wants to merge 2 commits intoray-project:masterfrom
Conversation
g-clef
changed the title
Collaborator
|
Thanks for the PR. Can we add a test for this? |
pang-wu
reviewed
Mar 2, 2025
Collaborator
pang-wu
left a comment
pang-wu
left a comment
There was a problem hiding this comment.
Can you elaborate a bit more on what problem you want to solve here?
If we want to bring runtime env to the ray actor, we probably also want to do that for the executors as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at issue #380 , it looks like the solution is fairly straightforward - since
_set_up_masterin ray_cluster.py already accepted akwargsparameter, but didn't use it, I renamed that toruntime_env, and passed it on to the RayDPSparkMaster options call.