Fix TaskContext leak and resource cleanup in getRDDPartition#463
Open
rexminnis wants to merge 1 commit intoray-project:masterfrom
Open
Fix TaskContext leak and resource cleanup in
getRDDPartition#463rexminnis wants to merge 1 commit intoray-project:masterfrom
rexminnis wants to merge 1 commit intoray-project:masterfrom
Conversation
resource cleanup in getRDDPartition getRDDPartition sets a dummy TaskContext but never unsets it. Since executor actors reuse threads (maxConcurrency=2), a stale TaskContext from one call leaks into subsequent operations on the same thread, which can cause subtle issues with metrics, accumulators, and task-local state. Additionally, if an exception occurs mid-method, neither the WriteChannel/ByteArrayOutputStream nor the BlockManager read locks are cleaned up. Wrap the method body in try/finally to guarantee: - BlockManager read locks are released via releaseAllLocksForTask - TaskContext is unset via TaskContext.unset() - WriteChannel and ByteArrayOutputStream are closed.
Contributor
Author
|
CI failure is pre-existing and unrelated to this change — All recent I'll open a separate PR to fix the CI workflow. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operations on the same thread, which can cause subtle issues with metrics, accumulators, and task-local state.
Test plan