This repository was archived by the owner on Jan 12, 2026. It is now read-only.
Merged
Conversation
Contributor
Author
|
@Yard1 Hi, could you please review this again? Thank you so much!! |
Member
|
@matthewdeng could you help get this merged and released? |
Contributor
Author
|
Hi @Yard1 Thanks for your review! I missed out a change and just added it. I need approval to run the workflow. Thank you! |
Member
|
@louis-huang Looks like just lint needs to be fixed |
Contributor
Author
|
@Yard1 Got it, fixed it now. Not get used to running format.sh whenever I make a change. Will remember this next time. Thank you for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new pull request to replace #298 because I'm unable to work on that branch.
I copied content from that pull requests:
Hi I added support to allow label as a list. So we can support reading data with multiple labels. This can then solve #286.
I verified new unit tests pass. Also test_matrix.py all pass with my local set up.
I verified locally by training a xgboost model with parquet data format, it works well. So far it should work well for parquet data format. Thank you!
I verified the change works with the blow code example: