Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update curl extension #16651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update curl extension #16651

wants to merge 1 commit into from

Conversation

gohadar
Copy link
Contributor

@gohadar gohadar commented Jan 27, 2025

Description

A MAJOR update to the existing cURL extension to turn it into more of a request manager to allow for better usability and a true replacement for tools like postman.

In this version there is a new command, Manage Requests, which opens the request manager to let the user start creating and working with their requests.

Notes

This PR is a result of an attempt at a new request manager which after some discussion, we've agreed to merge into this extension. Please feel free to also read up the discussion in the original PR

Screencast

All Requests Create Request Request View Response View

Checklist

- Removed .idea
- Fixed linting error
- Fixed linting error
- Merge branch \'contributions/merge-1737996913077\'
- Pull contributions
- Fixed linting error
- Merged with Rebound (declined) extension code
- Removed TODO
- Added metafiles for formatting
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: curl Issues related to the curl extension labels Jan 27, 2025
@raycastbot
Copy link
Collaborator

Thank you for your contribution! 🎉

🔔 @jonathangiardino @pernielsentikaer @bkeys818 @ridemountainpig you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@pernielsentikaer
Copy link
Collaborator

Thanks for your contribution 🔥

@jonathangiardino do you want to check this?

@pernielsentikaer pernielsentikaer self-assigned this Jan 28, 2025
@raycastbot
Copy link
Collaborator

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Feb 11, 2025
@pernielsentikaer
Copy link
Collaborator

@jonathangiardino are you still around?

@jonathangiardino
Copy link
Contributor

@jonathangiardino are you still around?

Hey @pernielsentikaer, yes!

I'll review this tomorrow 💪🏼

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Feb 12, 2025
@pernielsentikaer
Copy link
Collaborator

Thanks a bunch for taking the time 🔥

@jonathangiardino
Copy link
Contributor

jonathangiardino commented Feb 13, 2025

@gohadar Please review the following points:

  • Add query params does not work
  • “Save request” action does not work as expected, it resends the request instead of saving it, or maybe it saves it but it sends the request again
  • “Save request” action should be actually a command for the request response view once is complete, not in the make request view
  • It takes an enourmous amount of time to make a requests compared to before, it was almost instant. Why?
  • Requests history and Manage requests are a little ambiguous in my opinion, history saves them all by default why having a new command?
  • Can’t we just incorporate the views in manage requests into the history with an “manage” action?

@pernielsentikaer could you double check my list?

@raycastbot
Copy link
Collaborator

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension: curl Issues related to the curl extension extension fix / improvement Label for PRs with extension's fix improvements status: stalled Stalled due inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants