Add motion extension #17756

owendavidprice · 2025-03-11T14:40:40Z

Description

Screencast

Checklist

I read the extension guidelines
I read the documentation about publishing
I ran npm run build and tested this distribution build in Raycast
I checked that files in the assets folder are used by the extension itself
I checked that assets used by the README are placed outside of the metadata folder

- Fix code style issues - Remove edit task functionality and rename extension to Motion - Adding new features to the list task function - Remove old screenshots - Remove unused imports to fix ESLint errors - Add correctly sized screenshots for Raycast store - Fix unterminated string literal in debug-workspaces.tsx - Add missing showFailureToast imports - Rename screenshots for better clarity - Add screenshots for Raycast store - Fix code formatting with Prettier - Address PR feedback: Update error handling, clean up .gitignore, add metadata folder for screenshots - Fix AI evals configuration to match Raycast requirements - Update debug-workspaces.tsx - Update extension per Raycast store guidelines: Add AI evals, create metadata folder, remove hardcoded workspace ID, enhance Prettier config, fix README title

raycastbot · 2025-03-11T14:41:01Z

Congratulations on your new Raycast extension! 🚀

Due to our current reduced availability, the initial review may take up to 10-15 business days

Once the PR is approved and merged, the extension will be available on our Store.

owendavidprice · 2025-03-11T14:41:14Z

@pernielsentikaer here's the new pull request as discussed! thanks.

greptile-apps

PR Summary

This PR adds a new Motion task management extension for Raycast, enabling users to manage tasks, projects, and workspaces through Motion's API.

The metadata folder lacks required screenshots for view commands (add-task, list-tasks, delete-task, debug-workspaces) which are needed for the Raycast Store listing
The ask-motion AI tool in package.json has evals but should include more diverse test cases for better coverage
The list-tasks.tsx component has duplicate state updates in setFilteredTasks(tasks) that should be removed
Consider using showFailureToast from @raycast/utils in delete-task.tsx and list-tasks.tsx to simplify error handling
The debug-workspaces.tsx component could benefit from a loading indicator during API calls for better UX

_{💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!}

_{14 file(s) reviewed, 21 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-03-11T14:43:25Z

extensions/motion/package.json

+    "lint": "ray lint",
+    "prepublishOnly": "echo \"\\n\\nIt seems like you are trying to publish the Raycast extension to npm.\\n\\nIf you did intend to publish it to npm, remove the \\`prepublishOnly\\` script and rerun \\`npm publish\\` again.\\nIf you wanted to publish it to the Raycast Store instead, use \\`npm run publish\\` instead.\\n\\n\" && exit 1",
+    "publish": "npx @raycast/api@latest publish",
+    "save": "git add . && git commit -m 'Save changes' && git push"


style: The save script is not a standard Raycast extension script and could be removed

greptile-apps · 2025-03-11T14:43:27Z

extensions/motion/metadata/README.md

+1. `add-task.tsx` - Screenshot of the Add Task form
+2. `list-tasks.tsx` - Screenshot showing a list of tasks 
+3. `edit-task.tsx` - Screenshot of the Edit Task form
+4. `delete-task.tsx` - Screenshot of the Delete Task view
+5. `debug-workspaces.tsx` - Screenshot of the Workspace Details view


logic: The file mentions edit-task.tsx but this command is not defined in package.json. Either remove this line or add the command to package.json

greptile-apps · 2025-03-11T14:43:48Z

extensions/motion/README.md

+## Features
+
+- **Add Task**: Quickly create new tasks with title, description, due date, priority, project, and label
+- **Edit Task**: View and edit your existing tasks, including updating priorities, deadlines, and project assignments


logic: The 'Edit Task' feature is listed in the README but there is no corresponding command in package.json or implementation file

greptile-apps · 2025-03-11T14:43:48Z

extensions/motion/README.md

+```bash
+# Install dependencies
+npm install
+
+# Start development server
+npm run dev
+```


style: Code block should be removed since these commands are already documented in the Installation section

greptile-apps · 2025-03-11T14:44:08Z

extensions/motion/src/add-task.tsx

+        await showToast({
+          style: Toast.Style.Failure,
+          title: "Failed to initialize Motion client",
+          message: String(error),
+        });


style: Could be simplified using showFailureToast from @raycast/utils

Suggested change

await showToast({

style: Toast.Style.Failure,

title: "Failed to initialize Motion client",

message: String(error),

});

await showFailureToast("Failed to initialize Motion client", String(error));

greptile-apps · 2025-03-11T14:45:32Z

extensions/motion/src/api/motion.ts

+    async getTaskById(id: string): Promise<MotionTask> {
+      const url = `${BASE_URL}/tasks/${id}?workspaceId=${preferences.workspaceId}`;
+      logRequest("GET", url, headers);
+
+      const response = await fetch(url, {
+        method: "GET",
+        headers,
+      });
+
+      if (!response.ok) {
+        const responseText = await logResponse(response);
+        throw new Error(
+          `Failed to get task: ${response.statusText}${responseText ? ` - ${responseText}` : ""}`
+        );
+      }
+
+      return response.json() as Promise<MotionTask>;
+    },


logic: getTaskById lacks try-catch block for error handling, unlike other API methods

Suggested change

async getTaskById(id: string): Promise<MotionTask> {

const url = `${BASE_URL}/tasks/${id}?workspaceId=${preferences.workspaceId}`;

logRequest("GET", url, headers);

const response = await fetch(url, {

method: "GET",

headers,

});

if (!response.ok) {

const responseText = await logResponse(response);

throw new Error(

`Failed to get task: ${response.statusText}${responseText ? ` - ${responseText}` : ""}`

);

}

return response.json() as Promise<MotionTask>;

},

async getTaskById(id: string): Promise<MotionTask> {

const url = `${BASE_URL}/tasks/${id}?workspaceId=${preferences.workspaceId}`;

logRequest("GET", url, headers);

try {

const response = await fetch(url, {

method: "GET",

headers,

});

if (!response.ok) {

const responseText = await logResponse(response);

throw new Error(

`Failed to get task: ${response.statusText}${responseText ? ` - ${responseText}` : ""}`

);

}

return response.json() as Promise<MotionTask>;

} catch (error) {

console.error("[DEBUG] Get task by ID error:", error);

throw error;

}

},

greptile-apps · 2025-03-11T14:45:33Z

extensions/motion/src/api/motion.ts

+    async deleteTask(id: string): Promise<void> {
+      const url = `${BASE_URL}/tasks/${id}?workspaceId=${preferences.workspaceId}`;
+      logRequest("DELETE", url, headers);
+
+      const response = await fetch(url, {
+        method: "DELETE",
+        headers,
+      });
+
+      if (!response.ok) {
+        const responseText = await logResponse(response);
+        throw new Error(
+          `Failed to delete task: ${response.statusText}${responseText ? ` - ${responseText}` : ""}`
+        );
+      }
+    },


style: deleteTask should verify task exists before attempting deletion to prevent accidental removals

greptile-apps · 2025-03-11T14:45:43Z

extensions/motion/src/list-tasks.tsx

+      // Sort tasks by due date (most recent first)
+      const sortedTasks = [...tasksData].sort((a, b) => {
+        if (!a.dueDate) return 1;
+        if (!b.dueDate) return -1;
+        return new Date(a.dueDate).getTime() - new Date(b.dueDate).getTime();
+      });


logic: Tasks are sorted with most recent first, but the comparison is reversed - newer dates should return -1 for ascending order

Suggested change

// Sort tasks by due date (most recent first)

const sortedTasks = [...tasksData].sort((a, b) => {

if (!a.dueDate) return 1;

if (!b.dueDate) return -1;

return new Date(a.dueDate).getTime() - new Date(b.dueDate).getTime();

});

// Sort tasks by due date (most recent first)

const sortedTasks = [...tasksData].sort((a, b) => {

if (!a.dueDate) return 1;

if (!b.dueDate) return -1;

return new Date(b.dueDate).getTime() - new Date(a.dueDate).getTime();

});

greptile-apps · 2025-03-11T14:46:52Z

extensions/motion/src/tools/ask-motion.tsx

+    const motionClient = getMotionApiClient();
+    const tasks = await motionClient.getTasks();


logic: getTasks() call should be wrapped in a try-catch block separate from the main try-catch to handle API initialization errors distinctly from task fetching errors

greptile-apps · 2025-03-11T14:46:52Z

extensions/motion/src/tools/ask-motion.tsx

+    console.error("Error in Ask Motion tool:", error);
+
+    // Extract more useful information from the error
+    const errorDetails = String(error);


style: consider using showFailureToast from @raycast/utils for error handling

pernielsentikaer · 2025-03-12T07:48:50Z

extensions/motion/metadata/README.md

@@ -0,0 +1,18 @@
+# Screenshots for Motion Extension


Why do we have a markdown file in metadata? Let's remove it

andreaselia · 2025-04-26T22:33:41Z

Hey @owendavidprice 👋

Would you mind taking a look at the feedback above when you get a chance, please? 🙏

raycastbot added the new extension Label for PRs with new extensions label Mar 11, 2025

greptile-apps bot reviewed Mar 11, 2025

View reviewed changes

pernielsentikaer reviewed Mar 12, 2025

View reviewed changes

pernielsentikaer added the AI Extension label Mar 12, 2025

pernielsentikaer assigned andreaselia Apr 28, 2025

andreaselia added the status: awaiting response from dev label Apr 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add motion extension #17756

Add motion extension #17756

owendavidprice commented Mar 11, 2025 •

edited

Loading

raycastbot commented Mar 11, 2025

owendavidprice commented Mar 11, 2025

greptile-apps bot left a comment

greptile-apps bot Mar 11, 2025

greptile-apps bot Mar 11, 2025

greptile-apps bot Mar 11, 2025

greptile-apps bot Mar 11, 2025

greptile-apps bot Mar 11, 2025

greptile-apps bot Mar 11, 2025

greptile-apps bot Mar 11, 2025

greptile-apps bot Mar 11, 2025

greptile-apps bot Mar 11, 2025

greptile-apps bot Mar 11, 2025

pernielsentikaer Mar 12, 2025

andreaselia commented Apr 26, 2025

		const motionClient = getMotionApiClient();
		const tasks = await motionClient.getTasks();

Add motion extension #17756

Are you sure you want to change the base?

Add motion extension #17756

Conversation

owendavidprice commented Mar 11, 2025 • edited Loading

Description

Screencast

Checklist

raycastbot commented Mar 11, 2025

owendavidprice commented Mar 11, 2025

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Mar 11, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 11, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 11, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 11, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 11, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 11, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 11, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 11, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 11, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 11, 2025

Choose a reason for hiding this comment

pernielsentikaer Mar 12, 2025

Choose a reason for hiding this comment

andreaselia commented Apr 26, 2025

owendavidprice commented Mar 11, 2025 •

edited

Loading