Skip to content

Update fronius-inverter extension #17817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Olli0103
Copy link
Contributor

@Olli0103 Olli0103 commented Mar 13, 2025

Description

Screencast

Checklist

- added screenshots
- Changelog adaptions
- Merge branch \'contributions/merge-1741872285826\'
- Pull contributions
- Merge branch \'contributions/merge-1741872144029\'
- Pull contributions
- Add AI tools and improve documentation
- Pull contributions
- commented code, added changelog / readme
- add AI extension capabilities
- added api documentation
- changes from PR review
- package lock fix
- minor changes
- minor changes
- changes from PR review
- made the changes from PR review
- committed
- ...
- adapted the refresh actions
- removed locales from watch
- removed locales
- remove Preferences
- adding screenshots
- intial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: fronius-inverter Issues related to the fronius-inverter extension OP is author The OP of the PR is the author of the extension labels Mar 13, 2025
@raycastbot
Copy link
Collaborator

Thank you for the update! 🎉

Due to our current reduced availability, the initial review may take up to 10-15 business days

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds AI-powered analysis tools to the Fronius inverter extension, enabling real-time system monitoring, error troubleshooting, and performance optimization suggestions through Raycast's AI capabilities.

  • The new AI tools in package.json lack evals in the AI configuration - suggest adding at least one eval with reference to AI Evals Documentation
  • API calls in src/tools/analyzeSystem.ts and src/tools/explainErrors.ts should use showFailureToast from @raycast/utils for error handling
  • Missing metadata folder with screenshots for the view command dashboard in package.json - required for store submission
  • Consider adding subtitle to commands in package.json with "Fronius Inverter" to help users identify the service
  • The CHANGELOG.md entry for version 1.1 correctly uses {PR_MERGE_DATE} placeholder

💡 (5/5) You can turn off certain types of comments like style here!

9 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile

@Olli0103
Copy link
Contributor Author

@pernielsentikaer @thomaspaulmann Any updates on that one? Thats a bit "aged" :D

@andreaselia andreaselia self-assigned this May 8, 2025
@andreaselia
Copy link
Contributor

andreaselia commented May 8, 2025

Hey @Olli0103 👋

There are attributes in the package.json that don't exist, e.g. tools -> file. The same for within the evals.

Please ensure only valid properties found in the manifest are used.

Could you also confirm that the evals are passing on your end please?

@andreaselia
Copy link
Contributor

Also, can we remove the API documentation files from the extension and instead maybe include a link in the README to API documentation instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Extension extension fix / improvement Label for PRs with extension's fix improvements extension: fronius-inverter Issues related to the fronius-inverter extension OP is author The OP of the PR is the author of the extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants