Major improvement to Elgato Key Lights #18532
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ep window open, add error handling, update bonjour package, improve caching
…aintain Raycast window, add error handling, update bonjour package, and improve caching mechanism.
…and in Elgato Key Light extension. Enhance caching mechanism to ensure only reachable lights are used.
…fy title casing in package.json, and streamline toast notifications by removing dismiss actions in discoverLights.ts. Refactor timeout handling in elgato.ts and adjust type definitions in utils.ts.
…er temperature commands and Kelvin display, add comprehensive error handling for discovery and command operations, and synchronize settings across lights. Update changelog and README for new features and technical improvements.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Enhance Elgato Key Light extension: Update dependencies to latest versions, add new commands for managing presets, improve temperature conversion functions, and implement comprehensive error handling for key light operations. Update package.json and package-lock.json for dependency changes, and refactor code for better readability and maintainability.
…hing mechanism with expiration, and improve toast notifications for discovery and state changes. Modify toggle command to handle no lights found scenario and streamline code for better readability.
… @raycast/eslint-config, update package-lock.json with new dependencies, modify toggle command title for clarity, and refactor timeout handling in elgato.ts for improved readability.
raycastbot
added
extension fix / improvement
|
Thank you for your contribution! 🎉 🔔 @thomaspaulmann you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
…ght class for improved accessibility in subclasses.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR significantly enhances the Elgato Key Light extension with improved user interface feedback, better error handling, and more robust light discovery mechanisms.
- Added new
discoverLights.tscommand for forcing fresh discovery of Key Lights with comprehensive error handling - Replaced
showHUDwithshowToastacross all commands for better visual feedback while keeping Raycast window open - Improved temperature display by showing values in Kelvin (2900K-7000K) instead of percentages
- Enhanced caching mechanism with validation to ensure lights are still reachable
- Added proper error handling with nested try-catch blocks and specific error messages for different failure scenarios
- Updated from deprecated
bonjourtobonjour-servicepackage with proper TypeScript definitions
22 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile
…ht class to enhance accessibility.
…sing Math.max with COLD_TEMPERATURE as the lower bound, but COLD_TEMPERATURE is the coolest setting (143). For increasing temperature (making it warmer), you should be approaching WARM_TEMPERATURE (344). Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…arity, add AI evaluation scenarios for light control and preset management, and improve error handling in light discovery process.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…extensions into elgato-enhancements
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…extensions into elgato-enhancements
|
@thomaspaulmann I finally got all my changes in after your PR. |
…arity, replace showToast with showFailureToast for improved error handling in increaseTemperature and toggle commands, and remove unused imports in PresetForm component.
|
This pull request has been automatically marked as stale because it did not have any recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊 |
@thomaspaulmann any chance you can review? |
|
@pernielsentikaer is there anyone else that can review it. I understand if Thomas is busy :-). |
|
We should be able to review this tomorrow 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Features
User Interface Improvements
Technical Improvements
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool