Skip to content

Add subwatch extension #18929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add subwatch extension #18929

wants to merge 5 commits into from

Conversation

nirgn975
Copy link

@nirgn975 nirgn975 commented May 3, 2025

Description

Screencast

Checklist

@raycastbot
Copy link
Collaborator

Congratulations on your new Raycast extension! 🚀

You can expect an initial review within five business days.

Once the PR is approved and merged, the extension will be available on our Store.

@raycastbot raycastbot added the new extension Label for PRs with new extensions label May 3, 2025
@nirgn975 nirgn975 marked this pull request as ready for review May 3, 2025 11:45
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds a new Subwatch extension for managing subscription services, with features to track, alert and optimize subscription costs through integration with the Subwatch platform.

Key issues to address:

  • CHANGELOG.md has a typo in title ("ubwatch") and uses hardcoded date "2025-02-02" instead of required {PR_MERGE_DATE} template
  • Hardcoded Supabase API keys and endpoints in src/state.ts and other files pose security risks and should be moved to environment variables
  • Error toasts in src/manage-subscriptions.tsx and src/add-subscription.tsx incorrectly use Toast.Style.Success instead of Failure
  • Missing metadata folder with screenshots despite having view commands in package.json
  • Generic function name getStuff() in src/state.ts should be more descriptive like getSubscriptions()

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

11 file(s) reviewed, 21 comment(s)
Edit PR Review Bot Settings | Greptile

- fix: lint errors
- fix: greptile review changes
- lint errors
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR update improves the Subwatch extension with better error handling and code organization, but still has some critical issues to address.

Key points to address:

  • Hardcoded API key apiKey: "123" in manage-subscriptions command context should be removed
  • Hardcoded Supabase API key in preferences default value needs to be removed for security
  • Redundant API_KEY and API_URL environment variables should be removed since preferences are used instead
  • Missing validation for end_date being after start_date in add-subscription form
  • Inconsistent date type handling between interfaces (Date objects vs strings) in types.ts

Note: Previous review already covered metadata folder, CHANGELOG formatting, and other issues that have not yet been addressed.

7 file(s) reviewed, 9 comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants