Update migadu extension #18930
Update migadu extension #18930
Conversation
- Update changelog - Merge branch \'contributions/merge-1746273759075\' - Pull contributions - Display identity name to make it searchable
raycastbot
added
extension fix / improvement
|
Thank you for your contribution! 🎉 🔔 @xmok @LBBO you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the Migadu extension to make identities searchable by both name and address, improving user experience when searching for specific identities.
- Fixed typo in CHANGELOG.md: "theiry" should be "their" in the description
- List.Item title format changed to
${identity.name} (${identity.address})to enable name-based searching - The PR complements issue Add "Create anonymous identity" command to Migadu extension #14896 which adds anonymous identity creation functionality
Note: The changes are minimal and focused, with proper error handling and validation in place.
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
PR Summary
(updates since last review)
No major changes found since last review. The previous review already covered the key changes regarding making identities searchable by name and the typo fix in CHANGELOG.md. The format and placement of the changelog entry correctly follows the required guidelines with the {PR_MERGE_DATE} placeholder.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
Currently, identites are only searchable by their address and not their name. Especially in combination with #14896, this can be annoying most addresses are meaningless to me and I care much more about the name. Therefore, the main goal of this PR is to make the names searchable.
I tried adding the name to the keywords instead, since those are also searchable (see docs). However, the keywords seem to be matched just from start to end, so e.g. the name "Some Test" would be matched for the query "so" but not "te". I tried doing some ad-hoc stuff to make the keywords more useful but couldn't get it working. And since the names are probably interesting anyway, I just decided to display them in the title and use the regular filtering.
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder(Didn't check assets since I didn't make any changes related to assets)