-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Update curl extension #18931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update curl extension #18931
Conversation
Thank you for your contribution! 🎉 🔔 @jonathangiardino @pernielsentikaer @bkeys818 you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR enhances error handling in the cURL extension by adding detailed error messages from API responses when requests fail, improving debugging capabilities.
- Improved error message extraction in
Form.tsx
by checking multiple error response fields (message
,error
,detail
) and displaying them in the toast notification - Added new changelog entry correctly formatted with
{PR_MERGE_DATE}
template at the top ofCHANGELOG.md
- Consider using
showFailureToast
from@raycast/utils
instead of manualshowToast
for error handling - The error message extraction could be simplified by using optional chaining for nested properties
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
This PR updates dependencies in the cURL extension and further improves error handling implementation with modern React and Raycast API versions.
- Updated
@raycast/api
to ^1.94.0 and@raycast/utils
to ^1.19.1 inpackage.json
for improved error handling capabilities - Added React 18.2.0 as a direct dependency to ensure consistent React version usage
- Upgraded Node and React type definitions to latest versions for better TypeScript support
- Removed Swift-related build files from tracking in
.gitignore
The changes focus on modernizing the extension's dependencies while maintaining the improved error handling functionality from the previous review.
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
.swiftpm | ||
compiled_raycast_swift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: These Swift-related ignore patterns seem unnecessary for a JavaScript/TypeScript cURL extension. Consider removing them if Swift functionality is not being used.
.raycast-swift-build | |
.swiftpm | |
compiled_raycast_swift |
Hi @ridemountainpig👋 Thanks for your contribution 🔥 @jonathangiardino do you want to check this? |
Description
Enhanced the detail of the request error message displayed in the toast. Close #18923.
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are located outside the metadata folder if they were not generated with our metadata tool