Update flush-dns extension

[c0b41]

Description

Screencast

Checklist

• I read the extension guidelines
• I read the documentation about publishing
• I ran npm run build and tested this distribution build in Raycast
• I checked that files in the assets folder are used by the extension itself
• I checked that assets used in the README are located outside the metadata folder if they were not generated with our metadata tool

[raycastbot]

Thank you for your contribution! 🎉

🔔 @rasmusbe @tombonez you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

[greptile-apps]

PR Summary

This PR updates the flush-dns extension to support Windows platform while modifying the DNS cache flushing functionality for both macOS and Windows operating systems.

• Title in extensions/flush-dns/package.json should be "Flush DNS" (not "Flush Dns") since DNS is an acronym
• The launchCommand in extensions/flush-dns/src/index.ts should be wrapped in a try-catch block
• Consider using showFailureToast from @raycast/utils instead of custom error handling in handleExecutionError function
• Recommend adding a subtitle "System" to the command in package.json for better context
• Windows-specific error handling in handleExecutionError could be simplified by using showFailureToast

_{💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!}

_{2 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

style: 'Flush Dns' should be 'Flush DNS' since DNS is an acronym

Suggested change

	"title": "Flush Dns",
	"title": "Flush DNS",

[greptile-apps]

logic: getMacOSCommands is called without await but returns a Promise

Suggested change

	const macResult = getMacOSCommands(osCommandSet);
	const macResult = await getMacOSCommands(osCommandSet);

[rasmusbe]

Great addition! I'm unable to try the Windows part it since I only own a mac, but it looks valid. 👏

I haven't verified that the mac parts still work, I will be able to do that on Thursday since I'm not having access to my development computer until then but I've added some small feedback based on what I see in the code.

[rasmusbe]

'Flush Dns' should be 'Flush DNS' since DNS is an acronym

[c0b41]

Linter was complaining, that why i changed

[rasmusbe]

Should this be undefined or "cmd.exe" in that case. Feels like cmd.exe is making more sense, but I don't have a strong opinion regarding this.

[c0b41]

raycast windows don't have showHUD api right so hard to know if throwing error, but Nodejs docs says right here node uses process.env.ComSpec as default shell as cmd.exe