adding needed changes #18987

chkpwd · 2025-05-06T15:53:51Z

Description

This update introduces several improvements and fixes across the extension:

New Feature: The import command now performs all necessary setup and configuration actions automatically (d94ddeabc3c8).
New Feature: Added a new "overwrite preference" action to provide more control over import behaviors (ab363f78ab6d).
UI Enhancements: Introduced dynamic icon support for better visual feedback (7d077481b83a).
Refactors:
- Renamed the primary action variable for clarity (c4faec441f78).
- Set unused tasks to be disabled by default to reduce UI clutter (386fd572c2fa).
Fixes:
- Improved the path resolution mechanism to work at runtime (781b6e5df02d).
- Corrected logic in stripServiceName to better handle edge cases (8dcf2826f9eb).
- Resolved import paths using preferences, making the extension more configurable (28259c72872e).
Chores:
- Improved code organization by restructuring imports (0028da00ab27).
- Added logs to notify if a target folder already exists (4befca5a81ae).
- Updated function names and command casing for consistency and readability (1515dfa6e494, 23e7dcc9ba7a).

Checklist

I read the extension guidelines
I read the documentation about publishing
I ran npm run build and tested this distribution build in Raycast
I checked that files in the assets folder are used by the extension itself
I checked that assets used in the README are located outside the metadata folder if they were not generated with our metadata tool

raycastbot · 2025-05-06T15:54:15Z

Thank you for the update! 🎉

You can expect an initial review within five business days.

greptile-apps

PR Summary

This PR introduces significant improvements to the Ente Auth extension, focusing on path resolution, icon handling, and import/export functionality.

The changelog entry for bug fix needs {PR_MERGE_DATE} instead of hardcoded date 2024-11-14
The command title change from "Get TOTP" to "Get Totp" in package.json should be kept as "Get TOTP" since it's the unique ID
Remove example usage code at bottom of /src/helpers/icons.ts (lines 70-75)
showToast in /src/export.tsx should be replaced with showFailureToast from @raycast/utils for better error handling
The any type in icon matching function in /src/helpers/icons.ts should be properly typed for type safety

_{💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!}

_{13 file(s) reviewed, 15 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-05-06T15:54:53Z

extensions/ente-auth/src/constants/ente.ts

+import path from "path";
+
+export const DEFAULT_EXPORT_DIR_PATH = (): string => {
+  const exportPath = getPreferenceValues().exportPath || path.join(process.env.HOME || "", "Documents", "ente");


logic: process.env.HOME may be undefined on Windows. Consider using os.homedir() as the primary source

Suggested change

const exportPath = getPreferenceValues().exportPath || path.join(process.env.HOME || "", "Documents", "ente");

const exportPath = getPreferenceValues().exportPath || path.join(os.homedir(), "Documents", "ente");

greptile-apps · 2025-05-06T15:54:54Z

extensions/ente-auth/src/constants/ente.ts


-export const EXPORTPATH = getPreferenceValues().exportPath || `${DEFAULT_EXPORT_PATH}/ente_auth.txt`;
+export const EXPORT_FILE_PATH = `${DEFAULT_EXPORT_DIR_PATH()}/ente_auth.txt`;


style: DEFAULT_EXPORT_DIR_PATH() is called on every reference - consider memoizing the result

greptile-apps · 2025-05-06T15:55:08Z

extensions/ente-auth/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Ente Auth Changelog

+## [Bug fix] - 2024-11-14


syntax: The title should use the {PR_MERGE_DATE} placeholder instead of a hardcoded date. Change to ## [Bug fix] - {PR_MERGE_DATE}

Suggested change

## [Bug fix] - 2024-11-14

## [Bug fix] - {PR_MERGE_DATE}

greptile-apps · 2025-05-06T15:55:26Z

extensions/ente-auth/package.json

@@ -25,14 +25,15 @@
  "commands": [
    {
      "name": "index",
-      "title": "Get TOTP",
+      "title": "Get Totp",


style: Title case inconsistency - 'TOTP' was changed to 'Totp' which is less standard

Suggested change

"title": "Get Totp",

"title": "Get TOTP",

greptile-apps · 2025-05-06T15:56:11Z

extensions/ente-auth/src/export.tsx

  } catch (error) {
    showToast(Toast.Style.Failure, "Folder creation failed");
-    return <Detail markdown={`## Failed to create folder at \`${EXPORTPATH}\``} />;
+    return <Detail markdown={`## Failed to create folder at \`${DEFAULT_EXPORT_DIR_PATH}\``} />;


logic: DEFAULT_EXPORT_DIR_PATH is a function but missing () here - will display function definition instead of path

Suggested change

return <Detail markdown={`## Failed to create folder at \`${DEFAULT_EXPORT_DIR_PATH}\``} />;

return <Detail markdown={`## Failed to create folder at \`${DEFAULT_EXPORT_DIR_PATH()}\``} />;

greptile-apps · 2025-05-06T15:56:32Z

extensions/ente-auth/src/helpers/icons.ts

+    if (icons[key as keyof typeof icons].slug === serviceName) {
+      return icons[key as keyof typeof icons].svg;
+    }


style: Use Object.entries() or Object.keys() instead of for...in to avoid iterating over prototype chain

greptile-apps · 2025-05-06T15:57:29Z

extensions/ente-auth/src/import.tsx

+  if (!checkEnteBinary()) {
+    showToast(Toast.Style.Failure, "Ente binary not found");
+  }


logic: The function continues execution after showing the binary not found error. This should return early to prevent further operations.

Suggested change

if (!checkEnteBinary()) {

showToast(Toast.Style.Failure, "Ente binary not found");

}

if (!checkEnteBinary()) {

showToast(Toast.Style.Failure, "Ente binary not found");

return;

}

greptile-apps · 2025-05-06T15:57:30Z

extensions/ente-auth/src/import.tsx

+    createEntePath(DEFAULT_EXPORT_DIR_PATH());
+    exportEnteAuthSecrets();


logic: These operations could fail but their errors aren't being caught. They should be inside the try block or have their own error handling.

greptile-apps · 2025-05-06T15:57:31Z

extensions/ente-auth/src/import.tsx

-    style: Toast.Style.Animated,
-    title: "Importing secrets",
-  });
+  const toast = await showToast({ style: Toast.Style.Animated, title: "Importing secrets" });


style: Multiple toast notifications could cause race conditions. Consider using showFailureToast from @raycast/utils for error cases.

greptile-apps · 2025-05-06T15:57:32Z

extensions/ente-auth/src/import.tsx

+  if (getPreferenceValues().deleteExport == true) {
+    deleteEnteExport();
+  };


logic: deleteEnteExport() could fail but errors are not handled. This should be in a try-catch block.

pernielsentikaer · 2025-05-07T05:51:38Z

Hi @chkpwd👋

Thanks for your contribution 🔥

Could you look into the merge conflicts

chkpwd · 2025-05-07T18:25:25Z

Hey @pernielsentikaer, thanks for all your hard work! Done.

pernielsentikaer

Hi 👋

Looks good to me, approved 🔥

github-actions · 2025-05-08T07:05:59Z

Published to the Raycast Store:
https://raycast.com/chkpwd/ente-auth

raycastbot · 2025-05-08T07:06:01Z

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

chkpwd added 11 commits November 25, 2024 15:12

chore: change casing on cmd

23e7dcc

chore: update func names

1515dfa

fix: resolve paths from preferences

28259c7

chore: log if folder exist

4befca5

chore: organize imports

0028da0

fix(bug): allow path to be resolved during runtime

781b6e5

fix: adjust stripServiceName expression

8dcf282

add dynamic icon support

7d07748

refactor: set unused tasks to diasbled by default

386fd57

feat: add new overwrite preference action

ab363f7

refator: renamed primary action var

c4faec4

raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: ente-auth Issues related to the ente-auth extension OP is author The OP of the PR is the author of the extension labels May 6, 2025

greptile-apps bot reviewed May 6, 2025

View reviewed changes

feat: import now performs all needed actions

f04bf18

chkpwd force-pushed the feat/redo-imports branch from d94ddea to f04bf18 Compare May 6, 2025 16:02

chkpwd added 7 commits May 6, 2025 13:02

style: memoize the dir path

a1a172d

style: set title uppercase

b09aba8

update changelog

2eed5d3

style: switched to showFailureToast

cf801b7

style: add recursive to folder recreation

5864a67

style: add consistency with cli binary

478413d

not part of this pr

48088f7

chkpwd mentioned this pull request May 7, 2025

[Ente Auth] Ability to sync ente auth from raycast similar to Authy's extension #17029

Closed

pernielsentikaer self-assigned this May 7, 2025

Merge branch 'main' into feat/redo-imports

9464c0f

style: fix linting

0e09f27

pernielsentikaer approved these changes May 8, 2025

View reviewed changes

Update CHANGELOG.md and optimise images

ca4a1c5

raycastbot merged commit b13d3fc into raycast:main May 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding needed changes #18987

adding needed changes #18987

chkpwd commented May 6, 2025

raycastbot commented May 6, 2025

greptile-apps bot left a comment

greptile-apps bot May 6, 2025

greptile-apps bot May 6, 2025

greptile-apps bot May 6, 2025

greptile-apps bot May 6, 2025

greptile-apps bot May 6, 2025

greptile-apps bot May 6, 2025

greptile-apps bot May 6, 2025

greptile-apps bot May 6, 2025

greptile-apps bot May 6, 2025

greptile-apps bot May 6, 2025

pernielsentikaer commented May 7, 2025

chkpwd commented May 7, 2025

pernielsentikaer left a comment

github-actions bot commented May 8, 2025

raycastbot commented May 8, 2025

	const exportPath = getPreferenceValues().exportPath \|\| path.join(process.env.HOME \|\| "", "Documents", "ente");
	const exportPath = getPreferenceValues().exportPath \|\| path.join(os.homedir(), "Documents", "ente");


		export const EXPORTPATH = getPreferenceValues().exportPath \|\| `${DEFAULT_EXPORT_PATH}/ente_auth.txt`;
		export const EXPORT_FILE_PATH = `${DEFAULT_EXPORT_DIR_PATH()}/ente_auth.txt`;

		@@ -1,5 +1,8 @@
		# Ente Auth Changelog

		## [Bug fix] - 2024-11-14

	return <Detail markdown={`## Failed to create folder at \`${DEFAULT_EXPORT_DIR_PATH}\``} />;
	return <Detail markdown={`## Failed to create folder at \`${DEFAULT_EXPORT_DIR_PATH()}\``} />;

		createEntePath(DEFAULT_EXPORT_DIR_PATH());
		exportEnteAuthSecrets();

adding needed changes #18987

adding needed changes #18987

Conversation

chkpwd commented May 6, 2025

Description

Checklist

raycastbot commented May 6, 2025

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot May 6, 2025

Choose a reason for hiding this comment

greptile-apps bot May 6, 2025

Choose a reason for hiding this comment

greptile-apps bot May 6, 2025

Choose a reason for hiding this comment

greptile-apps bot May 6, 2025

Choose a reason for hiding this comment

greptile-apps bot May 6, 2025

Choose a reason for hiding this comment

greptile-apps bot May 6, 2025

Choose a reason for hiding this comment

greptile-apps bot May 6, 2025

Choose a reason for hiding this comment

greptile-apps bot May 6, 2025

Choose a reason for hiding this comment

greptile-apps bot May 6, 2025

Choose a reason for hiding this comment

greptile-apps bot May 6, 2025

Choose a reason for hiding this comment

pernielsentikaer commented May 7, 2025

chkpwd commented May 7, 2025

pernielsentikaer left a comment

Choose a reason for hiding this comment

github-actions bot commented May 8, 2025

raycastbot commented May 8, 2025