-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Update zen-browser extension #19013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update zen-browser extension #19013
Conversation
Thank you for your contribution! 🎉 🔔 @Keyruu @theherk @walker-tx @Jimmy-b36 @sdaza @elliothco you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds AI tools to the Zen Browser extension, enabling AI-powered new tab creation and history search functionality with comprehensive test cases and evals.
- Critical: SQL injection vulnerability in
whereClauses
function needs immediate fixing by using parameterized queries tools
section in package.json needs to includeai
withevals
(already present, good job!)getHistory
function should throw proper errors instead of returning error strings- Consider wrapping
openNewTab
andopenHistoryTab
AppleScript calls in try-catch blocks for better error handling - Recommend using
showFailureToast
from@raycast/utils
for error handling in the tools implementation
8 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
if (!fs.existsSync(dbPath)) { | ||
return "Zen Browser is not installed."; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Return type inconsistency - function returns either string or HistoryEntry[] which makes error handling unpredictable. Consider throwing an error instead
if (!fs.existsSync(dbPath)) { | |
return "Zen Browser is not installed."; | |
} | |
if (!fs.existsSync(dbPath)) { | |
throw new Error("Zen Browser is not installed."); | |
} |
Description
Add AI Tools to:
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are located outside the metadata folder if they were not generated with our metadata tool