Skip to content

Update zen-browser extension #19013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ridemountainpig
Copy link
Contributor

Description

Add AI Tools to:

  • Open New Tab
  • Search History

Screencast

Raycast 2025-05-08 at 11 57 24

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: zen-browser Issues related to the zen-browser extension OP is contributor The OP of the PR is a contributor of the extension labels May 8, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented May 8, 2025

Thank you for your contribution! 🎉

🔔 @Keyruu @theherk @walker-tx @Jimmy-b36 @sdaza @elliothco you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds AI tools to the Zen Browser extension, enabling AI-powered new tab creation and history search functionality with comprehensive test cases and evals.

  • Critical: SQL injection vulnerability in whereClauses function needs immediate fixing by using parameterized queries
  • tools section in package.json needs to include ai with evals (already present, good job!)
  • getHistory function should throw proper errors instead of returning error strings
  • Consider wrapping openNewTab and openHistoryTab AppleScript calls in try-catch blocks for better error handling
  • Recommend using showFailureToast from @raycast/utils for error handling in the tools implementation

8 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines +98 to +100
if (!fs.existsSync(dbPath)) {
return "Zen Browser is not installed.";
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Return type inconsistency - function returns either string or HistoryEntry[] which makes error handling unpredictable. Consider throwing an error instead

Suggested change
if (!fs.existsSync(dbPath)) {
return "Zen Browser is not installed.";
}
if (!fs.existsSync(dbPath)) {
throw new Error("Zen Browser is not installed.");
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Extension extension fix / improvement Label for PRs with extension's fix improvements extension: zen-browser Issues related to the zen-browser extension OP is contributor The OP of the PR is a contributor of the extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants