-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix: Add latest OpenAI models and consolidation system #19592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix: Add latest OpenAI models and consolidation system #19592
Conversation
Thank you for your contribution! 🎉 🔔 @alanzchen @one-data-cookie @JonathanAquino you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Updates OpenAI model support in ChatGPT Quick Actions extension with a significant refactor of model management, but includes several critical issues that need addressing.
scripts/models.js
includes non-existent models (GPT-4.1, GPT-4.1-mini, GPT-4.1-nano) - these should be removed as they don't exist in OpenAI's lineup- CHANGELOG.md contains duplicate entries with
{PR_MERGE_DATE}
template - these should be consolidated into a single entry - Some models listed as "Latest" (o1, o3) are actually preview/limited access models - this should be clearly documented
- Package template system is well-structured but pricing calculations in
util.ts
need validation against official OpenAI rates - Model consolidation system is a good architectural improvement but needs additional error handling in
build-package.js
7 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
b5eadee
to
bfc474c
Compare
bfc474c
to
3e2dcdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drewbabel Very neat, thanks for taking the time to consolidate it! 🚀
@@ -1,5 +1,15 @@ | |||
# ChatGPT Quick Actions Changelog | |||
|
|||
## [Models Update and Consolidation] - {PR_MERGE_DATE} | |||
|
|||
- Added latest OpenAI models: GPT-4.1, GPT-4.1 mini, GPT-4.1 nano, o1, o1-mini, o1-pro, o3, o3-mini, o4-mini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a useless nitpick – I'd use imperative mood instead of past tense in these, same as in commit messages and below.
"platforms": [ | ||
"macOS" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing an empty row at the end. Same in the other files below.
} | |
} | |
## Adding New Models | ||
|
||
1. Edit `scripts/models.js` | ||
2. Update pricing in `src/util.ts` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or similar.
2. Update pricing in `src/util.ts` | |
2. Update [pricing](https://openai.com/api/pricing/) in `src/util.ts` |
Fixes #19481 --> references PR #19485
This PR updates the ChatGPT Quick Actions extension with the latest OpenAI models and adds a consolidation system for easier maintenance.
Changes Made
Added Latest Models
Removed Obsolete Models
Updated Pricing Structure
prompt_token/output_token
toinput_token/output_token
Added Consolidation System
scripts/models.js
) instead of 9 placesnpm run build-package
script to auto-generate package.jsonRelated to previous PR #19485 - incorporates all reviewer feedback from @one-data-cookie.
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are located outside the metadata folder if they were not generated with our metadata tool