-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add gcs-uploader extension #24242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add gcs-uploader extension #24242
Conversation
- fix(publish): finalize all extensions for store release - fix(publish): fix validation and variable duplication in gcs-uploader - fix(publish): fix validation issues and prepare water-reminder for public store - fix(publish): set author and owner for gcs-uploader and water-reminder - Initial commit
|
Congratulations on your new Raycast extension! 🚀 Due to our current reduced availability, the initial review may take up to 10-15 business days. Once the PR is approved and merged, the extension will be available on our Store. |
Greptile SummaryAdds a new extension for uploading files to Google Cloud Storage with clipboard detection and CDN support. The extension checks clipboard for files first, then falls back to manual file picker if empty. Key concerns:
Confidence Score: 1/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (7)
-
extensions/gcs-uploader/package.json, line 39 (link)logic: hardcoded default bucket name - should be empty or use a generic placeholder
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
extensions/gcs-uploader/package.json, line 65 (link)logic: hardcoded default CDN URL - should be empty
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
extensions/gcs-uploader/package.json, line 88 (link)style:
node-fetchunnecessary in Node 21+ (fetch is built-in)Why: Unnecessary imports add... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Context Used: Rule from
dashboard- What: Do not import fetch in Node 21+, as it is a built-in global API. -
extensions/gcs-uploader/src/upload-file.tsx, line 23-25 (link)logic: manual
Preferencesinterface violates auto-generated types policy - remove and use auto-generated types fromraycast-env.d.tsNote: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Context Used: Rule from
dashboard- What: Don't manually definePreferencesforgetPreferenceValues()or commendsArgumentinterfa... (source) -
extensions/gcs-uploader/src/utils.ts, line 13-20 (link)logic: manual
Preferencesinterface violates auto-generated types policy - remove and use auto-generated types fromraycast-env.d.tsNote: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Context Used: Rule from
dashboard- What: Don't manually definePreferencesforgetPreferenceValues()or commendsArgumentinterfa... (source) -
extensions/gcs-uploader/src/utils.ts, line 11 (link)style:
node-fetchunnecessary in Node 21+ (fetch is built-in) - remove importWhy: Unnecessary imports add... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Context Used: Rule from
dashboard- What: Do not import fetch in Node 21+, as it is a built-in global API. -
extensions/gcs-uploader/src/utils.ts, line 113-123 (link)style:
confirmUploadfunction is defined but never used - remove unused code
7 files reviewed, 7 comments
- fix(gcs-uploader): address Greptile feedback and final formatting - fix(gcs-uploader): address Greptile feedback - remove hardcoded config, redundant types and deps, add metadata and changelog - fix(water-reminder): address feedback and update guidelines - fix(water-reminder): address Greptile feedback - fix shell injection, remove manual preferences, remove node-fetch, add changelog
- fix: force update dependencies to match Raycast Store CI requirements - fix(water-reminder): fix PR check failure - add metadata folder and remove node-fetch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: please update this to English
Currently, Raycast does not support localization. I recommend using English for now.
|
Hi 👋 Thanks for your contribution 💪 Could you look into the suggestions from Greptile and me? I'm looking forward to testing this extension again 🔥 I converted this PR into a draft until it's ready for the review, please press the button Feel free to contact me here or at Slack if you have any questions. |
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder