Skip to content

Conversation

@AdamVyborny
Copy link
Contributor

@AdamVyborny AdamVyborny commented Jan 7, 2026

Description

Updates node-csfd-api dependency from v2.11.0 to v4.1.2

Fixes #24228

The previous version of the node-csfd-api library had a bug causing TypeError: Cannot read properties of null (reading 'textContent') when viewing movie details. This update resolves the issue.

Screencast

No UI changes - this is a dependency update fix.

Checklist

- Merge branch \'contributions/merge-1767801861726\'
- Pull contributions
- Update CHANGELOG.md and optimise images
- chore(deps): update node-csfd-api to v4.1.2
- lint: apply automated code formatting fixes
- fix(ux): improve empty state messaging flow - Show proper initial state when no search performed - Display \'Searching...\' during active searches - Only show \'No results found\' after completed failed searches - Fix search function to return undefined for empty queries
- feat(ai): add comprehensive AI evaluations with mock data for ČSFD extension
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: csfd Issues related to the csfd extension AI Extension platform: macOS OP is author The OP of the PR is the author of the extension labels Jan 7, 2026
@raycastbot
Copy link
Collaborator

Thank you for the update! 🎉

Due to our current reduced availability, the initial review may take up to 10-15 business days.

@AdamVyborny AdamVyborny marked this pull request as ready for review January 7, 2026 16:11
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 7, 2026

Greptile Summary

This PR updates the node-csfd-api dependency from v2.11.0 to v4.1.2 to fix a crash that occurred when viewing movie details. The update addresses the reported issue where a null reference error (TypeError: Cannot read properties of null) was thrown when accessing certain movie details.

Changes Made:

  • Updated node-csfd-api dependency to v4.1.2 in package.json
  • Updated package-lock.json to reflect the new dependency version
  • Added changelog entry documenting the fix (v1.0.1)

Issue Found:

  • The changelog entry uses a hardcoded date 2025-01-07 instead of the required {PR_MERGE_DATE} placeholder for automatic date setting during release, violating repository standards.

Confidence Score: 4/5

  • This PR is safe to merge after fixing the changelog date format to use the {PR_MERGE_DATE} placeholder.
  • The PR contains a straightforward dependency update that fixes a reported bug in the node-csfd-api library. The update appears to be properly tested (author indicates running npm run build), and the change is well-documented in the changelog. However, the score is reduced by 1 point due to the violation of the changelog date placeholder convention, which must be corrected before merge.
  • CHANGELOG.md requires updating the date format to use {PR_MERGE_DATE} placeholder instead of hardcoded date.

Important Files Changed

Filename Overview
extensions/csfd/package.json Updated node-csfd-api dependency from v2.11.0 to v4.1.2 to fix a crash when viewing movie details caused by a null reference error in the API library.
extensions/csfd/CHANGELOG.md Added changelog entry for v1.0.1 documenting the fix, but uses a hardcoded date instead of the required {PR_MERGE_DATE} placeholder as per repository standards.
extensions/csfd/package-lock.json Automatically updated lock file reflecting the dependency version change from v2.11.0 to v4.1.2.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. extensions/csfd/CHANGELOG.md, line 3 (link)

    syntax: Use {PR_MERGE_DATE} placeholder instead of hardcoded date for automatic date setting during release.\n\n

    Context Used: Rule from dashboard - What: Changelog entries must use {PR_MERGE_DATE} placeholder in titles, be placed at the top of th... (source)

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@AdamVyborny
Copy link
Contributor Author

Additional Comments (1)

  1. extensions/csfd/CHANGELOG.md, line 3 (link)
    syntax: Use {PR_MERGE_DATE} placeholder instead of hardcoded date for automatic date setting during release.\n\n
    Context Used: Rule from dashboard - What: Changelog entries must use {PR_MERGE_DATE} placeholder in titles, be placed at the top of th... (source)

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

fixed

@0xdhrv 0xdhrv self-assigned this Jan 8, 2026
Copy link
Contributor

@0xdhrv 0xdhrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 0965b59 into raycast:main Jan 8, 2026
2 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Published to the Raycast Store:
https://raycast.com/adam_vyborny/csfd

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Extension extension: csfd Issues related to the csfd extension extension fix / improvement Label for PRs with extension's fix improvements OP is author The OP of the PR is the author of the extension platform: macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ČSFD] ERROR Cannot read properties of null (reading 'textContent')

4 participants