-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add no as a service #24268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no as a service #24268
Conversation
|
Congratulations on your new Raycast extension! 🚀 Due to our current reduced availability, the initial review may take up to 10-15 business days. Once the PR is approved and merged, the extension will be available on our Store. |
Greptile SummaryThis PR adds a new "No as a Service" extension that fetches humorous rejection reasons from the NaaS API (
Missing requirement: The extension has a view-type command but is missing the required Confidence Score: 4/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (2)
-
extensions/no-as-a-service/src/random-no.tsx, line 46 (link)syntax: The icon
arrow-clockwise.pngdoesn't exist in the assets folder. Use the built-in Raycast icon instead by importingIconfrom@raycast/apiand usingIcon.ArrowClockwise.Also add
Iconto the import on line 1:import { Detail, ActionPanel, Action, showToast, Toast, Icon } from "@raycast/api";
-
extensions/no-as-a-service/CHANGELOG.md, line 3 (link)style: Per repository guidelines, use
{PR_MERGE_DATE}placeholder instead of hardcoded date.Context Used: Rule from
dashboard- What: Changelog entries must use{PR_MERGE_DATE}placeholder in titles, be placed at the top of th... (source)
6 files reviewed, 2 comments
| <Action | ||
| title="Get Another No" | ||
| onAction={() => revalidate()} | ||
| shortcut={{ modifiers: ["cmd"], key: "r" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: use common keyboard shortcuts
If you can can use common keyboard shortcuts for this, you can also better support windows users.
References:
0xdhrv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion
|
Hi 👋 Thanks for your contribution 💪 I have now tested your extension, and I have some feedback ready for you:
I'm looking forward to testing this extension again 🔥 I converted this PR into a draft until it's ready for the review, please press the button Feel free to contact me here or at Slack if you have any questions. |
|
Thanks for the suggestion! I've updated the code to use Keyboard.Shortcut.Common.Refresh for better cross-platform support. |
Greptile found no issues!From now on, if a review finishes and we haven't found any issues, we will not post anything, but you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
0xdhrv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋
Thank you for your contribution 🔥
This looks good to me 🚀
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
This extension provides a quick and fun way to generate creative reasons to say "No" to requests, powered by the No-as-a-Service API (
naas.isalman.dev).Features:
Cmd + Rto get a new reason instantly if the first one doesn't fit.Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool