-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Update Wave extension - create draft invoice + show discounts in invoice
#24269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for the update! 🎉 Due to our current reduced availability, the initial review may take up to 10-15 business days. |
Greptile SummaryThis PR adds draft invoice creation functionality and displays discount information in invoice details. Key Changes:
Issues Found:
Confidence Score: 3/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (3)
-
extensions/wave/src/manage-wave.tsx, line 118 (link)logic: When
invoice.discounts.lengthis 0, this line produces an empty string, which breaks markdown table formatting. The table will have a blank line between rows instead of a proper row. -
extensions/wave/src/manage-wave.tsx, line 122 (link)syntax: This row is missing the leading pipe separator, making table formatting inconsistent with other rows.
-
extensions/wave/src/lib/components/create-invoice.tsx, line 109-111 (link)style: Duplicate
Form.Separatorcomponents - only one separator is needed between sections.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
9 files reviewed, 3 comments
pernielsentikaer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, approved 🔥
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
InvoiceChecklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool