Skip to content

Conversation

@hadihassan04
Copy link

@hadihassan04 hadihassan04 commented Jan 7, 2026

Description

Screencast

Checklist

@raycastbot raycastbot added new extension Label for PRs with new extensions platform: macOS labels Jan 7, 2026
@raycastbot
Copy link
Collaborator

Congratulations on your new Raycast extension! 🚀

Due to our current reduced availability, the initial review may take up to 10-15 business days.

Once the PR is approved and merged, the extension will be available on our Store.

@hadihassan04
Copy link
Author

Islamic Prayer Times

A Raycast extension that displays accurate Islamic prayer times in the macOS menu bar with real-time countdowns and customizable display options.

Features

  • Menu Bar Display: Shows next prayer with countdown or exact time
  • 5 Daily Prayers: Fajr, Sunrise, Dhuhr, Asr, Maghrib, Isha
  • 50+ Cities: Pre-populated major cities + custom city input
  • 14 Calculation Methods: Support for major Islamic calculation methods (ISNA, MWL, Umm Al-Qura, etc.)
  • Customizable Display:
    • Countdown mode or exact time mode
    • Icon only, text only, or both
  • Real-time Updates: Auto-refreshes hourly, countdown updates every few seconds

Technical Details

  • Uses Aladhan API for prayer times
  • Settings stored in Raycast Cache
  • TypeScript with proper error handling
  • ESLint and Prettier passing

Files

  • src/prayer.tsx - Menu bar command
  • src/settings.tsx - Settings panel
  • src/utils.ts - API and time utilities

@hadihassan04 hadihassan04 marked this pull request as ready for review January 7, 2026 19:34
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 7, 2026

Greptile Summary

This PR updates the prayer-times extension to restrict it to macOS only, removing Windows platform support.

Key Issues Found

  • Manual Preferences definitions: Both prayer.tsx and settings.tsx manually define Preferences types that are auto-generated in raycast-env.d.ts
  • Duplicate preferences: The city and calculationMethod preferences are duplicated across both commands instead of being unified as global preferences
  • Missing metadata folder: The extension has view-type commands but lacks the required metadata/ folder with Raycast-styled screenshots

Configuration

  • Prettier and ESLint configs follow Raycast standards correctly
  • CHANGELOG uses proper {PR_MERGE_DATE} placeholder formatting

Confidence Score: 2/5

  • This PR has critical architectural issues that must be resolved before merging
  • Manual Preferences type definitions will cause type mismatches and runtime errors; duplicate preferences across commands violate Raycast best practices; missing metadata folder is required for store submission
  • Pay close attention to package.json, src/prayer.tsx, and src/settings.tsx for the architectural issues

Important Files Changed

Filename Overview
extensions/prayer-times/package.json changed platform from macOS and Windows to macOS only; has duplicate preferences across commands that should be global
extensions/prayer-times/src/prayer.tsx menu bar command for prayer times; manually defines Preferences type that should be auto-generated
extensions/prayer-times/src/settings.tsx settings view command; manually defines Preferences type that should be auto-generated

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

@hadihassan04
Copy link
Author

hadihassan04 commented Jan 7, 2026

Greptile Summary

This PR updates the prayer-times extension to restrict it to macOS only, removing Windows platform support.

Key Issues Found

  • Manual Preferences definitions: Both prayer.tsx and settings.tsx manually define Preferences types that are auto-generated in raycast-env.d.ts
  • Duplicate preferences: The city and calculationMethod preferences are duplicated across both commands instead of being unified as global preferences
  • Missing metadata folder: The extension has view-type commands but lacks the required metadata/ folder with Raycast-styled screenshots

Configuration

  • Prettier and ESLint configs follow Raycast standards correctly
  • CHANGELOG uses proper {PR_MERGE_DATE} placeholder formatting

Confidence Score: 2/5

  • This PR has critical architectural issues that must be resolved before merging
  • Manual Preferences type definitions will cause type mismatches and runtime errors; duplicate preferences across commands violate Raycast best practices; missing metadata folder is required for store submission
  • Pay close attention to package.json, src/prayer.tsx, and src/settings.tsx for the architectural issues

Important Files Changed

Filename Overview
extensions/prayer-times/package.json changed platform from macOS and Windows to macOS only; has duplicate preferences across commands that should be global
extensions/prayer-times/src/prayer.tsx menu bar command for prayer times; manually defines Preferences type that should be auto-generated
extensions/prayer-times/src/settings.tsx settings view command; manually defines Preferences type that should be auto-generated

Resolved.

Copy link
Author

@hadihassan04 hadihassan04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new extension Label for PRs with new extensions platform: macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants